mirror of
https://github.com/discourse/discourse.git
synced 2025-06-04 11:11:13 +08:00
832ed8ce74
Now we have the search input showing in a few different configurations: * Welcome banner * Header field * Header icon And we can get to the search with both `/` and `Ctrl+F` shortcuts. These configurations can be used together, and we need to focus on the right search input at the right time. This commit fixes the shortcuts not working or showing the wrong thing in some cases, and adds a comprehensive system spec for all the variants.
72 lines
2.0 KiB
Ruby
72 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Welcome banner", type: :system do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
let(:banner) { PageObjects::Components::WelcomeBanner.new }
|
|
let(:search_page) { PageObjects::Pages::Search.new }
|
|
|
|
context "when welcome banner is enabled" do
|
|
before { SiteSetting.enable_welcome_banner = true }
|
|
|
|
it "shows for logged in and anonymous users" do
|
|
visit "/"
|
|
expect(banner).to be_visible
|
|
expect(banner).to have_anonymous_title
|
|
sign_in(current_user)
|
|
visit "/"
|
|
expect(banner).to have_logged_in_title(current_user.username)
|
|
end
|
|
|
|
it "only displays on top_menu routes" do
|
|
sign_in(current_user)
|
|
SiteSetting.remove_override!(:top_menu)
|
|
topic = Fabricate(:topic)
|
|
visit "/"
|
|
expect(banner).to be_visible
|
|
visit "/latest"
|
|
expect(banner).to be_visible
|
|
visit "/new"
|
|
expect(banner).to be_visible
|
|
visit "/unread"
|
|
expect(banner).to be_visible
|
|
visit "/hot"
|
|
expect(banner).to be_visible
|
|
visit "/tags"
|
|
expect(banner).to be_hidden
|
|
visit topic.relative_url
|
|
expect(banner).to be_hidden
|
|
end
|
|
|
|
it "hides welcome banner and shows header search on scroll, and vice-versa" do
|
|
SiteSetting.search_experience = "search_field"
|
|
Fabricate(:topic)
|
|
|
|
sign_in(current_user)
|
|
visit "/"
|
|
expect(banner).to be_visible
|
|
expect(search_page).to have_no_search_field
|
|
|
|
fake_scroll_down_long
|
|
|
|
expect(banner).to be_invisible
|
|
expect(search_page).to have_search_field
|
|
|
|
page.scroll_to(0, 0)
|
|
expect(banner).to be_visible
|
|
expect(search_page).to have_no_search_field
|
|
end
|
|
end
|
|
|
|
context "when welcome banner is not enabled" do
|
|
before { SiteSetting.enable_welcome_banner = false }
|
|
|
|
it "does not show the welcome banner for logged in and anonymous users" do
|
|
visit "/"
|
|
expect(banner).to be_hidden
|
|
sign_in(current_user)
|
|
visit "/"
|
|
expect(banner).to be_hidden
|
|
end
|
|
end
|
|
end
|