mirror of
https://github.com/discourse/discourse.git
synced 2025-06-01 08:49:03 +08:00
3187606d34
This commit replaces the `full_name_required` setting with a new `full_name_requirement` setting to allow more flexibility with the name field in the signup form. The new setting has 2 options, "Required at signup" and "Optional at signup", which are equivalent to the true/false possibilities of the old setting, and a third option "Hidden at signup" that hides the name field from the signup form, making it effectively optional too. New sites will have the "Hidden at signup" option as the default option, and existing site will continue to use the option that maps to their current configuration. Internal topic: t/136746.
237 lines
7.9 KiB
JavaScript
237 lines
7.9 KiB
JavaScript
import { click, fillIn, visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import sinon from "sinon";
|
|
import LoginMethod from "discourse/models/login-method";
|
|
import Site from "discourse/models/site";
|
|
import pretender, {
|
|
parsePostData,
|
|
response,
|
|
} from "discourse/tests/helpers/create-pretender";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
import { i18n } from "discourse-i18n";
|
|
|
|
acceptance("Create Account", function () {
|
|
test("create an account", async function (assert) {
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert.dom(".create-account").exists("it shows the create account modal");
|
|
|
|
await fillIn("#new-account-name", "Dr. Good Tuna");
|
|
await fillIn("#new-account-password", "cool password bro");
|
|
|
|
// without this double fill, field will sometimes being empty
|
|
// got consistent repro by having browser search bar focused when starting test
|
|
await fillIn("#new-account-email", "good.tuna@test.com");
|
|
await fillIn("#new-account-email", "good.tuna@test.com");
|
|
|
|
// Check username
|
|
await fillIn("#new-account-username", "taken");
|
|
assert
|
|
.dom("#username-validation.bad")
|
|
.exists("the username validation is bad");
|
|
await click(".d-modal__footer .btn-primary");
|
|
|
|
await fillIn("#new-account-username", "good-tuna");
|
|
assert
|
|
.dom("#username-validation.good")
|
|
.exists("the username validation is good");
|
|
|
|
pretender.post("/u", (request) => {
|
|
assert.step("request");
|
|
const data = parsePostData(request.requestBody);
|
|
assert.strictEqual(data.name, "Dr. Good Tuna");
|
|
assert.strictEqual(data.password, "cool password bro");
|
|
assert.strictEqual(data.email, "good.tuna@test.com");
|
|
assert.strictEqual(data.username, "good-tuna");
|
|
return response({ success: true });
|
|
});
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
assert
|
|
.dom(".d-modal__footer .btn-primary")
|
|
.isDisabled("create account is disabled");
|
|
|
|
assert.verifySteps(["request"]);
|
|
});
|
|
|
|
test("validate username", async function (assert) {
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
await fillIn("#new-account-email", "z@z.co");
|
|
await click(".d-modal__footer .btn-primary");
|
|
|
|
assert
|
|
.dom("#username-validation")
|
|
.hasText(i18n("user.username.required"), "shows signup error");
|
|
});
|
|
|
|
test("hidden instructions", async function (assert) {
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert
|
|
.dom("#account-email-validation-more-info")
|
|
.hasText(i18n("user.email.instructions"));
|
|
assert.dom("#username-validation-more-info").doesNotExist();
|
|
assert.dom("#password-validation-more-info").doesNotExist();
|
|
assert.dom("#fullname-validation-more-info").doesNotExist();
|
|
});
|
|
|
|
test("visible instructions", async function (assert) {
|
|
this.siteSettings.show_signup_form_username_instructions = true;
|
|
this.siteSettings.show_signup_form_password_instructions = true;
|
|
this.siteSettings.show_signup_form_full_name_instructions = true;
|
|
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert
|
|
.dom("#username-validation-more-info")
|
|
.hasText(i18n("user.username.instructions"));
|
|
assert
|
|
.dom("#password-validation-more-info")
|
|
.hasText(i18n("user.password.instructions", { count: 10 }));
|
|
assert
|
|
.dom("#fullname-validation-more-info")
|
|
.hasText(i18n("user.name.instructions_required"));
|
|
|
|
await fillIn("#new-account-email", "z@z.co");
|
|
await fillIn("#new-account-password", "supersecurepassword");
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
|
|
assert.dom("#username-validation").hasText(i18n("user.username.required"));
|
|
|
|
// only shows the instructions if the validation is not visible
|
|
assert.dom("#account-email-validation-more-info").doesNotExist();
|
|
assert.dom("#username-validation-more-info").doesNotExist();
|
|
assert.dom("#password-validation-more-info").doesNotExist();
|
|
assert.dom("#fullname-validation-more-info").exists();
|
|
});
|
|
|
|
test("can sign in using a third-party auth", async function (assert) {
|
|
sinon.stub(LoginMethod, "buildPostForm").callsFake((url) => {
|
|
assert.step("buildPostForm");
|
|
assert.strictEqual(url, "/auth/facebook?signup=true");
|
|
});
|
|
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
await click("#login-buttons button");
|
|
|
|
assert.verifySteps(["buildPostForm"]);
|
|
});
|
|
|
|
test("does not show passkeys button", async function (assert) {
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert
|
|
.dom(".d-modal.create-account .btn-primary")
|
|
.exists("create account button exists");
|
|
|
|
assert.dom(".passkey-login-button").doesNotExist();
|
|
});
|
|
});
|
|
|
|
acceptance("Create Account - full name requirement", function () {
|
|
test("full name required", async function (assert) {
|
|
const site = Site.current();
|
|
site.set("full_name_required_for_signup", true);
|
|
site.set("full_name_visible_in_signup", true);
|
|
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
await fillIn("#new-account-email", "z@z.co");
|
|
await fillIn("#new-account-username", "good-tuna");
|
|
await fillIn("#new-account-password", "cool password bro");
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
assert.dom("#fullname-validation").hasText(i18n("user.name.required"));
|
|
|
|
await fillIn("#new-account-name", "Full Name");
|
|
|
|
pretender.post("/u", (request) => {
|
|
assert.step("request");
|
|
const data = parsePostData(request.requestBody);
|
|
assert.strictEqual(data.name, "Full Name");
|
|
assert.strictEqual(data.password, "cool password bro");
|
|
assert.strictEqual(data.email, "z@z.co");
|
|
assert.strictEqual(data.username, "good-tuna");
|
|
return response({ success: true });
|
|
});
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
assert
|
|
.dom(".d-modal__footer .btn-primary")
|
|
.isDisabled("create account is disabled");
|
|
|
|
assert.verifySteps(["request"]);
|
|
});
|
|
|
|
test("full name hidden at signup", async function (assert) {
|
|
const site = Site.current();
|
|
site.set("full_name_required_for_signup", false);
|
|
site.set("full_name_visible_in_signup", false);
|
|
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert.dom("#new-account-name").doesNotExist();
|
|
|
|
await fillIn("#new-account-email", "z@z.co");
|
|
await fillIn("#new-account-username", "good-tuna");
|
|
await fillIn("#new-account-password", "cool password bro");
|
|
|
|
pretender.post("/u", (request) => {
|
|
assert.step("request");
|
|
const data = parsePostData(request.requestBody);
|
|
assert.strictEqual(data.password, "cool password bro");
|
|
assert.strictEqual(data.email, "z@z.co");
|
|
assert.strictEqual(data.username, "good-tuna");
|
|
return response({ success: true });
|
|
});
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
assert
|
|
.dom(".d-modal__footer .btn-primary")
|
|
.isDisabled("create account is disabled");
|
|
|
|
assert.verifySteps(["request"]);
|
|
});
|
|
|
|
test("full name optional at signup", async function (assert) {
|
|
const site = Site.current();
|
|
site.set("full_name_required_for_signup", false);
|
|
site.set("full_name_visible_in_signup", true);
|
|
|
|
await visit("/");
|
|
await click("header .sign-up-button");
|
|
|
|
assert.dom("#new-account-name").exists();
|
|
|
|
await fillIn("#new-account-email", "z@z.co");
|
|
await fillIn("#new-account-username", "good-tuna");
|
|
await fillIn("#new-account-password", "cool password bro");
|
|
|
|
pretender.post("/u", (request) => {
|
|
assert.step("request");
|
|
const data = parsePostData(request.requestBody);
|
|
assert.strictEqual(data.password, "cool password bro");
|
|
assert.strictEqual(data.email, "z@z.co");
|
|
assert.strictEqual(data.username, "good-tuna");
|
|
return response({ success: true });
|
|
});
|
|
|
|
await click(".d-modal__footer .btn-primary");
|
|
assert
|
|
.dom(".d-modal__footer .btn-primary")
|
|
.isDisabled("create account is disabled");
|
|
|
|
assert.verifySteps(["request"]);
|
|
});
|
|
});
|