mirror of
https://github.com/discourse/discourse.git
synced 2025-05-07 03:43:00 +08:00
b235799792
This commit is a series of fixes to improve stability of system tests following the use of threadsafe: * Jobs.run_immediately in before block was causing issues * During test a js error could be caused by an undefined this.details in chat-live-pane * Apply the chat composer click trick everywhere when sending a message, it ensures we are not hiding anything with autocomplete * There was another case not using send_message yet
68 lines
1.9 KiB
Ruby
68 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "JIT messages", type: :system, js: true do
|
|
fab!(:channel_1) { Fabricate(:chat_channel) }
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
fab!(:other_user) { Fabricate(:user) }
|
|
|
|
let(:chat) { PageObjects::Pages::Chat.new }
|
|
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
|
|
|
before do
|
|
channel_1.add(current_user)
|
|
chat_system_bootstrap
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when mentioning a user not on the channel" do
|
|
xit "displays a mention warning" do
|
|
Jobs.run_immediately!
|
|
|
|
chat.visit_channel(channel_1)
|
|
channel.send_message("hi @#{other_user.username}")
|
|
|
|
expect(page).to have_content(
|
|
I18n.t("js.chat.mention_warning.without_membership.one", username: other_user.username),
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when mentioning a user who can’t access the channel" do
|
|
fab!(:group_1) { Fabricate(:group) }
|
|
fab!(:private_channel_1) { Fabricate(:private_category_channel, group: group_1) }
|
|
|
|
before do
|
|
group_1.add(current_user)
|
|
private_channel_1.add(current_user)
|
|
end
|
|
|
|
it "displays a mention warning" do
|
|
Jobs.run_immediately!
|
|
|
|
chat.visit_channel(private_channel_1)
|
|
channel.send_message("hi @#{other_user.username}")
|
|
|
|
expect(page).to have_content(
|
|
I18n.t("js.chat.mention_warning.cannot_see.one", username: other_user.username),
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when mention a group" do
|
|
context "when group can't be mentioned" do
|
|
fab!(:group_1) { Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:nobody]) }
|
|
|
|
it "displays a mention warning" do
|
|
Jobs.run_immediately!
|
|
|
|
chat.visit_channel(channel_1)
|
|
channel.send_message("hi @#{group_1.name}")
|
|
|
|
expect(page).to have_content(
|
|
I18n.t("js.chat.mention_warning.group_mentions_disabled.one", group_name: group_1.name),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|