mirror of
https://github.com/discourse/discourse.git
synced 2025-06-24 19:01:33 +08:00

Adds support to typing `---`, `___` or `***` to create a horizontal rule. Converting when typing `---` is actually written here as an en-dash + `-`, because the typographer replacements extension turns `--` into an en-dash first. `___` and `***` are only triggered after a whitespace, because they could also mean bold+italic.
454 lines
14 KiB
Ruby
454 lines
14 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Composer - ProseMirror editor", type: :system do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:tag)
|
|
let(:cdp) { PageObjects::CDP.new }
|
|
let(:composer) { PageObjects::Components::Composer.new }
|
|
let(:rich) { composer.rich_editor }
|
|
|
|
before do
|
|
sign_in(user)
|
|
SiteSetting.rich_editor = true
|
|
end
|
|
|
|
def open_composer_and_toggle_rich_editor
|
|
page.visit "/new-topic"
|
|
expect(composer).to be_opened
|
|
composer.toggle_rich_editor
|
|
composer.focus
|
|
end
|
|
|
|
it "hides the Composer container's preview button" do
|
|
page.visit "/new-topic"
|
|
|
|
expect(composer).to be_opened
|
|
expect(composer).to have_composer_preview_toggle
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_no_composer_preview_toggle
|
|
end
|
|
|
|
context "with autocomplete" do
|
|
it "triggers an autocomplete on mention" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("@#{user.username}")
|
|
|
|
expect(composer).to have_mention_autocomplete
|
|
end
|
|
|
|
it "triggers an autocomplete on hashtag" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("##{tag.name}")
|
|
|
|
expect(composer).to have_hashtag_autocomplete
|
|
end
|
|
|
|
it "triggers an autocomplete on emoji" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content(":smile")
|
|
|
|
expect(composer).to have_emoji_autocomplete
|
|
end
|
|
end
|
|
|
|
context "with inputRules" do
|
|
it "supports > to create a blockquote" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("> This is a blockquote")
|
|
|
|
expect(rich).to have_css("blockquote", text: "This is a blockquote")
|
|
end
|
|
|
|
it "supports n. to create an ordered list" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("1. Item 1\n5. Item 2")
|
|
|
|
expect(rich).to have_css("ol li", text: "Item 1")
|
|
expect(find("ol ol", text: "Item 2")["start"]).to eq("5")
|
|
end
|
|
|
|
it "supports *, - or + to create an unordered list" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("* Item 1\n")
|
|
composer.type_content("- Item 2\n")
|
|
composer.type_content("+ Item 3")
|
|
|
|
expect(rich).to have_css("ul ul li", count: 3)
|
|
end
|
|
|
|
it "supports ``` or 4 spaces to create a code block" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("```\nThis is a code block")
|
|
composer.send_keys(%i[shift enter])
|
|
composer.type_content(" This is a code block")
|
|
|
|
expect(rich).to have_css("pre code", text: "This is a code block", count: 2)
|
|
end
|
|
|
|
it "supports 1-6 #s to create a heading" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("# Heading 1\n")
|
|
composer.type_content("## Heading 2\n")
|
|
composer.type_content("### Heading 3\n")
|
|
composer.type_content("#### Heading 4\n")
|
|
composer.type_content("##### Heading 5\n")
|
|
composer.type_content("###### Heading 6\n")
|
|
|
|
expect(rich).to have_css("h1", text: "Heading 1")
|
|
expect(rich).to have_css("h2", text: "Heading 2")
|
|
expect(rich).to have_css("h3", text: "Heading 3")
|
|
expect(rich).to have_css("h4", text: "Heading 4")
|
|
expect(rich).to have_css("h5", text: "Heading 5")
|
|
expect(rich).to have_css("h6", text: "Heading 6")
|
|
end
|
|
|
|
it "supports _ or * to create an italic text" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("_This is italic_\n")
|
|
composer.type_content("*This is italic*")
|
|
|
|
expect(rich).to have_css("em", text: "This is italic", count: 2)
|
|
end
|
|
|
|
it "supports __ or ** to create a bold text" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("__This is bold__\n")
|
|
composer.type_content("**This is bold**")
|
|
|
|
expect(rich).to have_css("strong", text: "This is bold", count: 2)
|
|
end
|
|
|
|
it "supports ` to create a code text" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("`This is code`")
|
|
|
|
expect(rich).to have_css("code", text: "This is code")
|
|
end
|
|
|
|
it "supports typographer replacements" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content(
|
|
"foo +- bar... test???? wow!!!! x,, y-- --- a--> b<-- c-> d<- e<-> f<--> (tm) (pa)",
|
|
)
|
|
|
|
expect(rich).to have_css(
|
|
"p",
|
|
text: "foo ± bar… test??? wow!!! x, y– — a–> b←- c→ d← e←> f←→ ™ ¶",
|
|
)
|
|
end
|
|
|
|
it "supports ---, *** or ___ to create a horizontal rule" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Hey\n---\nThere\n*** Friend\n___ ")
|
|
|
|
expect(rich).to have_css("hr", count: 3)
|
|
end
|
|
end
|
|
|
|
context "with oneboxing" do
|
|
let(:cdp) { PageObjects::CDP.new }
|
|
|
|
before do
|
|
def body(title)
|
|
<<~HTML
|
|
<html>
|
|
<head>
|
|
<title>#{title}</title>
|
|
<meta property="og:title" content="#{title}">
|
|
<meta property="og:description" content="This is an example site">
|
|
</head>
|
|
<body>
|
|
<h1>#{title}</h1>
|
|
<p>This domain is for use in examples.</p>
|
|
</body>
|
|
</html>
|
|
HTML
|
|
end
|
|
|
|
stub_request(:head, "https://example.com").to_return(status: 200)
|
|
stub_request(:get, "https://example.com").to_return(status: 200, body: body("Example Site 1"))
|
|
|
|
stub_request(:head, "https://example2.com").to_return(status: 200)
|
|
stub_request(:get, "https://example2.com").to_return(
|
|
status: 200,
|
|
body: body("Example Site 2"),
|
|
)
|
|
|
|
stub_request(:head, "https://example3.com").to_return(status: 200)
|
|
stub_request(:get, "https://example3.com").to_return(
|
|
status: 200,
|
|
body: body("Example Site 3"),
|
|
)
|
|
end
|
|
|
|
it "creates an inline onebox for links within text" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Check out this link ")
|
|
cdp.write_clipboard("https://example.com")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
composer.type_content(" in the middle of text")
|
|
|
|
expect(rich).to have_css(
|
|
"a.inline-onebox[href='https://example.com']",
|
|
text: "Example Site 1",
|
|
)
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value(
|
|
"Check out this link https://example.com in the middle of text",
|
|
)
|
|
end
|
|
|
|
it "creates a full onebox for standalone links" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
cdp.write_clipboard("https://example.com")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
page.send_keys(:enter, :enter)
|
|
|
|
expect(rich).to have_css("div.onebox-wrapper[data-onebox-src='https://example.com']")
|
|
expect(rich).to have_content("Example Site 1")
|
|
expect(rich).to have_content("This is an example site")
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value("https://example.com\n\n")
|
|
end
|
|
|
|
it "creates an inline onebox for links that are part of a paragraph" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Some text ")
|
|
cdp.write_clipboard("https://example.com")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
composer.type_content(" more text")
|
|
|
|
expect(rich).to have_no_css("div.onebox-wrapper")
|
|
expect(rich).to have_css("a.inline-onebox", text: "Example Site 1")
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value("Some text https://example.com more text")
|
|
end
|
|
|
|
it "does not create oneboxes inside code blocks" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("```")
|
|
cdp.write_clipboard("https://example.com")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
|
|
expect(rich).to have_css("pre code")
|
|
expect(rich).to have_no_css("div.onebox-wrapper")
|
|
expect(rich).to have_no_css("a.inline-onebox")
|
|
expect(rich).to have_content("https://example.com")
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value("```\nhttps://example.com\n```")
|
|
end
|
|
|
|
it "creates oneboxes for mixed content" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
markdown = <<~MARKDOWN
|
|
https://example.com
|
|
|
|
Check this https://example.com and see if it fits you
|
|
|
|
https://example2.com
|
|
|
|
An inline to https://example2.com with text around it
|
|
|
|
https://example3.com
|
|
|
|
Another one for https://example3.com then
|
|
|
|
https://example.com
|
|
|
|
Phew, repeating https://example.com now
|
|
|
|
https://example2.com
|
|
|
|
And some text again https://example2.com
|
|
|
|
https://example3.com
|
|
|
|
Ok, that is it https://example3.com
|
|
MARKDOWN
|
|
cdp.write_clipboard(markdown)
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
|
|
expect(rich).to have_css("a.inline-onebox", count: 6)
|
|
expect(rich).to have_css(
|
|
"a.inline-onebox[href='https://example.com']",
|
|
text: "Example Site 1",
|
|
)
|
|
expect(rich).to have_css(
|
|
"a.inline-onebox[href='https://example2.com']",
|
|
text: "Example Site 2",
|
|
)
|
|
expect(rich).to have_css(
|
|
"a.inline-onebox[href='https://example3.com']",
|
|
text: "Example Site 3",
|
|
)
|
|
|
|
expect(rich).to have_css("div.onebox-wrapper", count: 6)
|
|
expect(rich).to have_css("div.onebox-wrapper[data-onebox-src='https://example.com']")
|
|
expect(rich).to have_css("div.onebox-wrapper[data-onebox-src='https://example2.com']")
|
|
expect(rich).to have_css("div.onebox-wrapper[data-onebox-src='https://example3.com']")
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value(markdown[0..-2])
|
|
end
|
|
|
|
it "creates inline oneboxes for repeated links in different paste events" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Hey")
|
|
cdp.write_clipboard("https://example.com")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
composer.type_content("and")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
|
|
expect(rich).to have_css(
|
|
"a.inline-onebox[href='https://example.com']",
|
|
text: "Example Site 1",
|
|
count: 2,
|
|
)
|
|
|
|
composer.toggle_rich_editor
|
|
|
|
expect(composer).to have_value("Hey https://example.com and https://example.com")
|
|
end
|
|
end
|
|
|
|
context "with keymap" do
|
|
PLATFORM_KEY_MODIFIER = SystemHelpers::PLATFORM_KEY_MODIFIER
|
|
it "supports Ctrl + B to create a bold text" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content([PLATFORM_KEY_MODIFIER, "b"])
|
|
composer.type_content("This is bold")
|
|
|
|
expect(rich).to have_css("strong", text: "This is bold")
|
|
end
|
|
|
|
it "supports Ctrl + I to create an italic text" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content([PLATFORM_KEY_MODIFIER, "i"])
|
|
composer.type_content("This is italic")
|
|
|
|
expect(rich).to have_css("em", text: "This is italic")
|
|
end
|
|
|
|
xit "supports Ctrl + K to create a link" do
|
|
open_composer_and_toggle_rich_editor
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "k"])
|
|
page.send_keys("https://www.example.com\t")
|
|
page.send_keys("This is a link")
|
|
page.send_keys(:enter)
|
|
|
|
expect(rich).to have_css("a", text: "This is a link")
|
|
end
|
|
|
|
it "supports Ctrl + Shift + 7 to create an ordered list" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Item 1")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "7"])
|
|
|
|
expect(rich).to have_css("ol li", text: "Item 1")
|
|
end
|
|
|
|
it "supports Ctrl + Shift + 8 to create a bullet list" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("Item 1")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "8"])
|
|
|
|
expect(rich).to have_css("ul li", text: "Item 1")
|
|
end
|
|
|
|
it "supports Ctrl + Shift + 9 to create a blockquote" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("This is a blockquote")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "9"])
|
|
|
|
expect(rich).to have_css("blockquote", text: "This is a blockquote")
|
|
end
|
|
|
|
it "supports Ctrl + Shift + 1-6 for headings, 0 for reset" do
|
|
open_composer_and_toggle_rich_editor
|
|
(1..6).each do |i|
|
|
composer.type_content("\nHeading #{i}")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, i.to_s])
|
|
|
|
expect(rich).to have_css("h#{i}", text: "Heading #{i}")
|
|
end
|
|
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "0"])
|
|
expect(rich).not_to have_css("h6")
|
|
end
|
|
|
|
it "supports Ctrl + Z and Ctrl + Shift + Z to undo and redo" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("This is a test")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, "z"])
|
|
|
|
expect(rich).not_to have_css("p", text: "This is a test")
|
|
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "z"])
|
|
|
|
expect(rich).to have_css("p", text: "This is a test")
|
|
end
|
|
|
|
it "supports Ctrl + Shift + _ to create a horizontal rule" do
|
|
open_composer_and_toggle_rich_editor
|
|
composer.type_content("This is a test")
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "_"])
|
|
|
|
expect(rich).to have_css("hr")
|
|
end
|
|
end
|
|
|
|
describe "pasting content" do
|
|
it "does not freeze the editor when pasting markdown code blocks without a language" do
|
|
cdp.allow_clipboard
|
|
open_composer_and_toggle_rich_editor
|
|
|
|
# The example is a bit convoluted, but it's the simplest way to reproduce the issue.
|
|
cdp.write_clipboard <<~MARKDOWN
|
|
```
|
|
puts SiteSetting.all_settings(filter_categories: ["uncategorized"]).map { |setting| setting[:setting] }.join("\n")
|
|
```
|
|
MARKDOWN
|
|
composer.type_content("This is a test\n\n")
|
|
page.send_keys([PLATFORM_KEY_MODIFIER, "v"])
|
|
expect(page.driver.browser.logs.get(:browser)).not_to include(
|
|
"Maximum call stack size exceeded",
|
|
)
|
|
expect(rich).to have_css("pre code", wait: 1)
|
|
expect(rich).to have_css("select.code-language-select", wait: 1)
|
|
end
|
|
end
|
|
|
|
describe "trailing paragraph" do
|
|
it "ensures there is always a trailing paragraph" do
|
|
open_composer_and_toggle_rich_editor
|
|
|
|
expect(rich).to have_css("p", count: 1)
|
|
composer.type_content("This is a test")
|
|
|
|
expect(rich).to have_css("p", count: 1)
|
|
expect(rich).to have_css("p", text: "This is a test", count: 1)
|
|
|
|
composer.send_keys([PLATFORM_KEY_MODIFIER, :shift, "_"]) # Insert a horizontal rule
|
|
expect(rich).to have_css("hr", count: 1)
|
|
expect(rich).to have_css("p", count: 2) # New paragraph inserted after the ruler
|
|
end
|
|
end
|
|
end
|