mirror of
https://github.com/discourse/discourse.git
synced 2025-06-14 19:29:21 +08:00
4d0a817f40
Previously we were compiling core and theme CSS into two targets: Desktop and Mobile. The majority of both files was the 'common' css. This commit splits those common styles into their own targets so that there is less duplication. This should improve compilation times + cache reuse, as well as opening the door for experiments with media-query-based mobile-modes. The only functional change is that we can no longer use `@extend` to copy 'common' rules in core to mobile/desktop. This is probably for the best. Duplication and/or mixins are a more native-css pattern for this. Plugins already have a common / mobile / desktop pattern, so are unchanged by this commit.
38 lines
1.3 KiB
Ruby
38 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Stylesheet::Manager::ScssChecker do
|
|
fab!(:theme)
|
|
|
|
describe "#has_scss" do
|
|
it "should return true when theme has scss" do
|
|
scss_theme = Fabricate(:theme, component: true)
|
|
scss_theme.set_field(target: :common, name: "scss", value: ".scss{color: red;}")
|
|
scss_theme.save!
|
|
|
|
embedded_scss_theme = Fabricate(:theme, component: true)
|
|
embedded_scss_theme.set_field(
|
|
target: :common,
|
|
name: "embedded_scss",
|
|
value: ".scss{color: red;}",
|
|
)
|
|
embedded_scss_theme.save!
|
|
|
|
theme_ids = [scss_theme.id, embedded_scss_theme.id]
|
|
|
|
desktop_theme_checker = described_class.new(:common_theme, theme_ids)
|
|
|
|
expect(desktop_theme_checker.has_scss(scss_theme.id)).to eq(true)
|
|
expect(desktop_theme_checker.has_scss(embedded_scss_theme.id)).to eq(false)
|
|
|
|
embedded_theme_checker = described_class.new(:embedded_theme, theme_ids)
|
|
|
|
expect(embedded_theme_checker.has_scss(scss_theme.id)).to eq(false)
|
|
expect(embedded_theme_checker.has_scss(embedded_scss_theme.id)).to eq(true)
|
|
end
|
|
|
|
it "should return false when theme does not have scss" do
|
|
expect(described_class.new(:desktop_theme, [theme.id]).has_scss(theme.id)).to eq(false)
|
|
end
|
|
end
|
|
end
|