mirror of
https://github.com/discourse/discourse.git
synced 2025-06-04 11:11:13 +08:00

This commit is replacing the system specs driver (selenium) by Playwright: https://playwright.dev/ We are still using Capybara to write the specs but they will now be run by Playwright. To achieve this we are using the non official ruby driver: https://github.com/YusukeIwaki/capybara-playwright-driver ### Notable changes - `CHROME_DEV_TOOLS` has been removed, it's not working well with playwright use `pause_test` and inspect browser for now. - `fill_in` is not generating key events in playwright, use `send_keys` if you need this. ### New spec options #### trace Allows to capture a trace in a zip file which you can load at https://trace.playwright.dev or locally through `npx playwright show-trace /path/to/trace.zip` _Example usage:_ ```ruby it "shows bar", trace: true do visit("/") find(".foo").click expect(page).to have_css(".bar") end ``` #### video Allows to capture a video of your spec. _Example usage:_ ```ruby it "shows bar", video: true do visit("/") find(".foo").click expect(page).to have_css(".bar") end ``` ### New env variable #### PLAYWRIGHT_SLOW_MO_MS Allow to force playwright to wait DURATION (in ms) at each action. _Example usage:_ ``` PLAYWRIGHT_SLOW_MO_MS=1000 rspec foo_spec.rb ``` #### PLAYWRIGHT_HEADLESS Allow to be in headless mode or not. Default will be headless. _Example usage:_ ``` PLAYWRIGHT_HEADLESS=0 rspec foo_spec.rb # will show the browser ``` ### New helpers #### with_logs Allows to access the browser logs and check if something specific has been logged. _Example usage:_ ```ruby with_logs do |logger| # do something expect(logger.logs.map { |log| log[:message] }).to include("foo") end ``` #### add_cookie Allows to add a cookie on the browser session. _Example usage:_ ```ruby add_cookie(name: "destination_url", value: "/new") ``` #### get_style Get the property style value of an element. _Example usage:_ ```ruby expect(get_style(find(".foo"), "height")).to eq("200px") ``` #### get_rgb_color Get the rgb color of an element. _Example usage:_ ```ruby expect(get_rgb_color(find("html"), "backgroundColor")).to eq("rgb(170, 51, 159)") ```
188 lines
5.6 KiB
Ruby
188 lines
5.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Dismissing New", type: :system do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
|
|
let(:discovery) { PageObjects::Pages::Discovery.new }
|
|
let(:topic_list_controls) { PageObjects::Components::TopicListControls.new }
|
|
let(:topic_list) { PageObjects::Components::TopicList.new }
|
|
let(:dismiss_new_modal) { PageObjects::Modals::DismissNew.new }
|
|
let(:topic_view) { PageObjects::Components::TopicView.new }
|
|
|
|
describe "when a user has an unread post" do
|
|
fab!(:topic) { Fabricate(:topic, user: user) }
|
|
fab!(:post1) { create_post(user: user, topic: topic) }
|
|
fab!(:post2) { create_post(topic: topic) }
|
|
|
|
it "should untrack topics across sessions after the user dismisses it" do
|
|
sign_in(user)
|
|
|
|
visit("/unread")
|
|
|
|
using_session(:tab_1) do
|
|
sign_in(user)
|
|
|
|
visit("/t/#{topic.id}")
|
|
|
|
expect(topic_view).to have_tracking_status("tracking")
|
|
end
|
|
|
|
topic_list_controls.dismiss_unread(untrack: true)
|
|
|
|
using_session(:tab_1) { expect(topic_view).to have_tracking_status("regular") }
|
|
end
|
|
|
|
context "when dismissing new on a category's topic list" do
|
|
fab!(:category) { Fabricate(:category_with_definition) }
|
|
fab!(:subcategory) { Fabricate(:category_with_definition, parent_category: category) }
|
|
fab!(:category_topic) { Fabricate(:topic, category: category, user: user) }
|
|
fab!(:category_post1) { create_post(user: user, topic: category_topic) }
|
|
fab!(:category_post2) { create_post(topic: category_topic) }
|
|
fab!(:subcategory_topic) { Fabricate(:topic, category: subcategory, user: user) }
|
|
fab!(:subcategory_post1) { create_post(user: user, topic: subcategory_topic) }
|
|
fab!(:subcategory_post2) { create_post(topic: subcategory_topic) }
|
|
|
|
it "should dismiss unread posts for the category and its subcategories" do
|
|
sign_in(user)
|
|
|
|
visit("/c/#{category.id}/l/unread")
|
|
|
|
expect(topic_list_controls).to have_unread(count: 2)
|
|
|
|
topic_list_controls.dismiss_unread
|
|
|
|
expect(topic_list_controls).to have_unread(count: 0)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "when a user has a new topic" do
|
|
fab!(:topic)
|
|
|
|
it "should remove the new topic across sessions after the user dismisses it" do
|
|
tab_1 = open_new_window(:tab)
|
|
switch_to_window(tab_1)
|
|
sign_in(user)
|
|
visit("/new")
|
|
|
|
expect(topic_list_controls).to have_new(count: 1)
|
|
|
|
tab_2 = open_new_window(:tab)
|
|
switch_to_window(tab_2)
|
|
sign_in(user)
|
|
visit("/new")
|
|
|
|
expect(topic_list_controls).to have_new(count: 1)
|
|
|
|
switch_to_window(tab_1)
|
|
topic_list_controls.dismiss_new
|
|
|
|
expect(topic_list_controls).to have_new(count: 0)
|
|
|
|
switch_to_window(tab_2)
|
|
expect(topic_list_controls).to have_new(count: 0)
|
|
end
|
|
end
|
|
|
|
describe "when the `experimental_new_new_view_groups` site setting is enabled" do
|
|
fab!(:group) { Fabricate(:group).tap { |g| g.add(user) } }
|
|
fab!(:new_topic) { Fabricate(:topic, user: user) }
|
|
fab!(:post1) { create_post(user: user) }
|
|
fab!(:post2) { create_post(topic: post1.topic) }
|
|
|
|
before { SiteSetting.experimental_new_new_view_groups = group.name }
|
|
|
|
it "should remove the new topic and post across sessions after the user dismisses it" do
|
|
tab_1 = open_new_window(:tab)
|
|
switch_to_window(tab_1)
|
|
sign_in(user)
|
|
visit("/new")
|
|
|
|
expect(topic_list_controls).to have_new(count: 2)
|
|
|
|
tab_2 = open_new_window(:tab)
|
|
switch_to_window(tab_2)
|
|
sign_in(user)
|
|
visit("/new")
|
|
|
|
expect(topic_list_controls).to have_new(count: 2)
|
|
|
|
switch_to_window(tab_1)
|
|
topic_list_controls.dismiss_new
|
|
dismiss_new_modal.click_dismiss
|
|
|
|
expect(dismiss_new_modal).to be_closed
|
|
expect(topic_list_controls).to have_new(count: 0)
|
|
|
|
switch_to_window(tab_2)
|
|
expect(topic_list_controls).to have_new(count: 0)
|
|
|
|
switch_to_window(tab_1)
|
|
topic_list_controls.click_latest
|
|
|
|
expect(topic_list_controls).to have_new(count: 0)
|
|
end
|
|
|
|
it "displays confirmation modal with preselected options" do
|
|
sign_in(user)
|
|
|
|
visit("/new")
|
|
|
|
expect(topic_list).to have_topic(new_topic)
|
|
expect(topic_list).to have_topic(post1.topic)
|
|
|
|
topic_list_controls.dismiss_new
|
|
|
|
expect(dismiss_new_modal).to have_dismiss_topics_checked
|
|
expect(dismiss_new_modal).to have_dismiss_posts_checked
|
|
expect(dismiss_new_modal).to have_untrack_unchecked
|
|
|
|
dismiss_new_modal.click_dismiss
|
|
|
|
expect(topic_list).to have_no_topics
|
|
end
|
|
|
|
context "with a tagged topic" do
|
|
fab!(:tag)
|
|
fab!(:tagged_topic) { Fabricate(:topic, tags: [tag]) }
|
|
fab!(:tagged_first_post) { Fabricate(:post, topic: tagged_topic) }
|
|
|
|
it "works on tag routes" do
|
|
sign_in(user)
|
|
|
|
visit("/tag/#{tag.name}/l/new")
|
|
|
|
expect(topic_list).to have_topics(count: 1)
|
|
expect(topic_list).to have_topic(tagged_first_post.topic)
|
|
|
|
topic_list_controls.dismiss_new
|
|
dismiss_new_modal.click_dismiss
|
|
|
|
expect(topic_list).to have_no_topics
|
|
|
|
visit("/new")
|
|
expect(topic_list).to have_topic(post1.topic)
|
|
end
|
|
|
|
it "works on regular routes after visiting tagged route" do
|
|
sign_in(user)
|
|
|
|
visit("/tag/#{tag.name}/l/new")
|
|
|
|
expect(topic_list).to have_topics(count: 1)
|
|
|
|
discovery.tag_drop.select_row_by_value("all-tags")
|
|
|
|
expect(topic_list).to have_topics(count: 3)
|
|
|
|
discovery.nav_item("new").click
|
|
|
|
topic_list_controls.dismiss_new
|
|
dismiss_new_modal.click_dismiss
|
|
|
|
expect(topic_list).to have_no_topics
|
|
end
|
|
end
|
|
end
|
|
end
|