mirror of
https://github.com/discourse/discourse.git
synced 2025-04-30 07:14:37 +08:00
8be39c5bf0
This commit improves a few aspects regarding group name validation: - `min_username_length` and `max_username_length` are validated with the shortest and longest names of users and groups - skip validation of the group name when the group is an automatic one
43 lines
1.2 KiB
Ruby
43 lines
1.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class MaxUsernameLengthValidator
|
|
MAX_USERNAME_LENGTH_RANGE = 8..60
|
|
|
|
def initialize(opts = {})
|
|
@opts = opts
|
|
end
|
|
|
|
def valid_value?(value)
|
|
if !MAX_USERNAME_LENGTH_RANGE.cover?(value)
|
|
@max_range_violation = true
|
|
return false
|
|
end
|
|
|
|
if value < SiteSetting.min_username_length
|
|
@min_value_violation = true
|
|
return false
|
|
end
|
|
|
|
@username = User.where("length(username) > ?", value).pick(:username)
|
|
@group_name = Group.where(automatic: false).where("length(name) > ?", value).pick(:name)
|
|
|
|
@username.blank? && @group_name.blank?
|
|
end
|
|
|
|
def error_message
|
|
if @max_range_violation
|
|
I18n.t(
|
|
"site_settings.errors.invalid_integer_min_max",
|
|
min: MAX_USERNAME_LENGTH_RANGE.begin,
|
|
max: MAX_USERNAME_LENGTH_RANGE.end,
|
|
)
|
|
elsif @min_value_violation
|
|
I18n.t("site_settings.errors.max_username_length_range")
|
|
elsif @username.present?
|
|
I18n.t("site_settings.errors.max_username_length_exists", username: @username)
|
|
elsif @group_name.present?
|
|
I18n.t("site_settings.errors.max_group_name_length_exists", group_name: @group_name)
|
|
end
|
|
end
|
|
end
|