From 20f6a256d5ad8c434bb1bbd17c5fa19f072d5708 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Mon, 13 Nov 2017 13:18:36 +1030 Subject: [PATCH] Only touch orders property if we're going to add to it --- .../sticky/src/Listener/PinStickiedDiscussionsToTop.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/sticky/src/Listener/PinStickiedDiscussionsToTop.php b/extensions/sticky/src/Listener/PinStickiedDiscussionsToTop.php index 78fc69610..af454efdf 100755 --- a/extensions/sticky/src/Listener/PinStickiedDiscussionsToTop.php +++ b/extensions/sticky/src/Listener/PinStickiedDiscussionsToTop.php @@ -45,16 +45,16 @@ class PinStickiedDiscussionsToTop $search = $event->search; $query = $search->getQuery(); - if (! is_array($query->orders)) { - $query->orders = []; - } - // If we are viewing a specific tag, then pin all stickied // discussions to the top no matter what. $gambits = $search->getActiveGambits(); foreach ($gambits as $gambit) { if ($gambit instanceof TagGambit) { + if (! is_array($query->orders)) { + $query->orders = []; + } + array_unshift($query->orders, ['column' => 'is_sticky', 'direction' => 'desc']); return;