From 220c1ac2d19de952918495cb4ca98375d970dc26 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Tue, 5 May 2015 17:04:42 +0930 Subject: [PATCH] Change extend function so that a value doesn't have to be returned override should be used instead to override the return value. --- js/lib/extension-utils.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/js/lib/extension-utils.js b/js/lib/extension-utils.js index 373d35d71..862d80bc3 100644 --- a/js/lib/extension-utils.js +++ b/js/lib/extension-utils.js @@ -1,16 +1,17 @@ export function extend(object, func, extension) { - var oldFunc = object[func]; + var original = object[func]; object[func] = function() { var args = [].slice.apply(arguments); - var value = oldFunc.apply(this, args); - return extension.apply(this, [value].concat(args)); + var value = original.apply(this, args); + extension.apply(this, [value].concat(args)); + return value; } }; export function override(object, func, override) { - var parent = object[func]; + var original = object[func]; object[func] = function() { var args = [].slice.apply(arguments); - return override.apply(this, [parent.bind(this)].concat(args)); + return override.apply(this, [original.bind(this)].concat(args)); } -} +};