github-mirror/framework
github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-05-17 03:42:33 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Service Provider: Move loadViewsFrom() to boot()

Browse Source 
This method relies on the "view" being bound in the IoC container.
This is only guaranteed after all register() methods have run, thus
it should be done in boot().
This commit is contained in:
Franz Liedke 2018-04-25 00:05:12 +02:00
parent 076288db21
commit 24fd2f32c7
No known key found for this signature in database
GPG Key ID: 9A0231A879B055F4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Install/InstallServiceProvider.php
View File

@ -53,8 +53,6 @@ class InstallServiceProvider extends AbstractServiceProvider
$this->app->singleton('flarum.install.routes', function () {
return new RouteCollection;
});
$this->loadViewsFrom(__DIR__.'/../../views/install', 'flarum.install');
}
/**
@ -62,6 +60,8 @@ class InstallServiceProvider extends AbstractServiceProvider
*/
public function boot()
{
$this->loadViewsFrom(__DIR__.'/../../views/install', 'flarum.install');
$this->populateRoutes($this->app->make('flarum.install.routes'));
}