github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-05-28 19:06:35 +08:00
Code Issues Actions 20 Packages Projects Releases Wiki Activity

Make integration tests independent

Browse Source 
This creates a dedicated test suite for integration tests. All of them
can be run independently, and there is no order dependency - previously,
all integration tests needed the installer test to run first, and they
would fail if installation failed.

Now, the developer will have to set up a Flarum database to be used by
these tests. A setup script to make this simple will be added in the
next commit.

Small tradeoff: the installer is NOT tested in our test suite anymore,
only implicitly through the setup script. If we decide that this is a
problem, we can still set up separate, dedicated installer tests which
should probably test the web installer.
This commit is contained in:
Franz Liedke
2019-01-30 21:15:27 +01:00
parent 4d10536d35
commit cf746079ed
22 changed files with 416 additions and 419 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/integration/api/Controller/CreateGroupControllerTest.php
View File

@ -13,6 +13,7 @@ namespace Flarum\Tests\integration\api\Controller;
use Flarum\Api\Controller\CreateGroupController;
use Flarum\Group\Group;
use Flarum\User\User;
use Illuminate\Support\Str;
class CreateGroupControllerTest extends ApiControllerTestCase
@ -26,6 +27,24 @@ class CreateGroupControllerTest extends ApiControllerTestCase
'color' => null
];
public function setUp()
{
parent::setUp();
$this->prepareDatabase([
'users' => [
$this->adminUser(),
$this->normalUser(),
],
'groups' => [
$this->adminGroup(),
],
'group_user' => [
['user_id' => 1, 'group_id' => 1],
],
]);
}
/**
* @test
* @expectedException \Illuminate\Validation\ValidationException
@ -33,7 +52,7 @@ class CreateGroupControllerTest extends ApiControllerTestCase
*/
public function admin_cannot_create_group_without_data()
{
$this->actor = $this->getAdminUser();
$this->actor = User::find(1);
$this->callWith();
}
@ -43,7 +62,7 @@ class CreateGroupControllerTest extends ApiControllerTestCase
*/
public function admin_can_create_group()
{
$this->actor = $this->getAdminUser();
$this->actor = User::find(1);
$response = $this->callWith($this->data);
@ -65,14 +84,8 @@ class CreateGroupControllerTest extends ApiControllerTestCase
*/
public function unauthorized_user_cannot_create_group()
{
$this->actor = $this->getNormalUser();
$this->actor = User::find(2);
$this->callWith($this->data);
}
public function tearDown()
{
Group::where('icon', $this->data['icon'])->delete();
parent::tearDown();
}
}