github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-05-23 07:09:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make integration tests independent

Browse Source 
This creates a dedicated test suite for integration tests. All of them
can be run independently, and there is no order dependency - previously,
all integration tests needed the installer test to run first, and they
would fail if installation failed.

Now, the developer will have to set up a Flarum database to be used by
these tests. A setup script to make this simple will be added in the
next commit.

Small tradeoff: the installer is NOT tested in our test suite anymore,
only implicitly through the setup script. If we decide that this is a
problem, we can still set up separate, dedicated installer tests which
should probably test the web installer.
This commit is contained in:
Franz Liedke
2019-01-30 21:15:27 +01:00
parent 4d10536d35
commit cf746079ed
22 changed files with 416 additions and 419 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/integration/api/Controller/CreateUserControllerTest.php
View File

@ -26,6 +26,23 @@ class CreateUserControllerTest extends ApiControllerTestCase
'email' => 'test@machine.local'
];
public function setUp()
{
parent::setUp();
$this->prepareDatabase([
'users' => [
$this->adminUser(),
],
'groups' => [
$this->adminGroup(),
],
'group_user' => [
['user_id' => 1, 'group_id' => 1],
],
]);
}
/**
* @test
* @expectedException \Illuminate\Validation\ValidationException
@ -60,7 +77,7 @@ class CreateUserControllerTest extends ApiControllerTestCase
*/
public function admins_can_create_activated_users()
{
$this->actor = $this->getAdminUser();
$this->actor = User::find(1);
$response = $this->callWith(array_merge($this->data, [
'isEmailConfirmed' => 1
@ -90,10 +107,4 @@ class CreateUserControllerTest extends ApiControllerTestCase
$settings->set('allow_sign_up', true);
}
}
public function tearDown()
{
User::where('username', $this->data['username'])->delete();
parent::tearDown();
}
}