github-mirror/framework
2
0
Fork 0
mirror of https://github.com/flarum/framework.git synced 2025-05-30 20:15:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove temporary file after avatar upload failure. closes flarum/core#999

Browse Source
This commit is contained in:
Toby Zerner
2016-08-27 23:53:02 +09:30
parent 82be1cea5d
commit d5797dae79
1 changed files with 41 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Core/Command/UploadAvatarHandler.php
View File

@ -10,6 +10,7 @@
namespace Flarum\Core\Command; namespace Flarum\Core\Command;
use Exception;
use Flarum\Core\Access\AssertPermissionTrait; use Flarum\Core\Access\AssertPermissionTrait;
use Flarum\Core\Repository\UserRepository; use Flarum\Core\Repository\UserRepository;
use Flarum\Core\Support\DispatchEventsTrait; use Flarum\Core\Support\DispatchEventsTrait;
@ -84,6 +85,7 @@ class UploadAvatarHandler
$tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar'); $tmpFile = tempnam($this->app->storagePath().'/tmp', 'avatar');
$command->file->moveTo($tmpFile); $command->file->moveTo($tmpFile);
try {
$file = new UploadedFile( $file = new UploadedFile(
$tmpFile, $tmpFile,
$command->file->getClientFilename(), $command->file->getClientFilename(),
@ -125,5 +127,10 @@ class UploadAvatarHandler
$this->dispatchEventsFor($user, $actor); $this->dispatchEventsFor($user, $actor);
return $user; return $user;
} catch (Exception $e) {
@unlink($tmpFile);
throw $e;
}
} }
} }