24964b94bf
Mark notification as read without visiting discussion ( #1874 )
2019-09-09 23:36:06 +02:00
2b624c935d
Bundled output for commit 2e647cdda8e23cc3c95ad8c834839349de602dc1 [skip ci]
2019-09-09 21:07:00 +00:00
2e647cdda8
Fix error thrown if textarea doesn't exist in TextEditor ( #1852 )
...
* Prevent textarea not existing from causing errors to be thrown
* Replace [0] with .length
2019-09-09 17:05:11 -04:00
ba175144f4
listen and restart currently fail in the queue, see #1879
2019-09-09 15:47:56 +02:00
e9af36ab47
Bundled output for commit 8b3913339af368ded760e31ff17168dadb3ab567 [skip ci]
2019-09-08 17:33:39 +00:00
8b3913339a
Fix the new edit user permission label ( #1870 )
2019-09-08 13:31:57 -04:00
3cced4156f
Add DB prefix to PHP tests ( #1855 )
...
* Add test job with PHP 7.3, MySQL & custom prefix
* Add prefix MariaDB test
* Add PHP 7.4 to tests
* Remove PHP 7.4 from tests
This reverts commit 270cba2f5f3883cba856d891e3b2f5feda8a2b01.
2019-09-08 13:28:39 -04:00
e88a9394ed
Add back defaults for language and direction attributes ( #1860 )
2019-09-05 08:28:52 +02:00
ba73c59601
Bundled output for commit 0191babb05b0ffa1443447809686c1141a35b04f [skip ci]
2019-09-05 00:34:59 +00:00
0191babb05
Optimize ScrollListener performance
...
Listen to "scroll" event and throttle callback executions instead
of actively polling for changes to the scroll position.
Fixes #1222 .
2019-09-05 02:17:09 +02:00
ed51f9ff0a
Fix failing test
2019-09-05 00:07:40 +02:00
0a2bdbaa09
Debug mode: Include stacktrace in JSON-API errors
...
Refs #1843 , #1865 .
2019-09-04 23:35:32 +02:00
26229db1fd
Refactor JSON-API error formatter
2019-09-04 23:30:22 +02:00
1aef3162be
Apply fixes from StyleCI ( #1867 )
...
[ci skip] [skip ci]
2019-09-04 01:44:59 +02:00
dcf88df0c7
Restore error details in JSON-API error formatter
...
Fixes #1865 . Refs #1843 .
2019-09-04 01:44:22 +02:00
3eb28dfb16
Convert controller test to request test
...
This further decouples these tests from the implementation (i.e. which
controller are we calling?).
2019-09-04 01:27:24 +02:00
1d43371fa9
Allow formatting post content without a request ( #1848 )
2019-09-04 00:12:28 +02:00
4df455cf04
Add Edit User permission to permissions grid ( #1859 )
2019-09-03 23:54:38 +02:00
2c43ccf66c
Merge pull request #1854 from flarum/fl/1641-fix-status-codes
...
Error handling: Fix status codes
2019-09-02 16:33:48 +02:00
1d010efbca
Bump lodash from 4.17.11 to 4.17.15 in /js ( #1863 )
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.11 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15 )
Signed-off-by: dependabot[bot] <support@github.com >
2019-08-28 09:11:25 +02:00
2135d5908e
Bump mixin-deep from 1.3.1 to 1.3.2 in /js ( #1862 )
...
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep ) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases )
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2 )
Signed-off-by: dependabot[bot] <support@github.com >
2019-08-28 09:06:38 +02:00
9640dd6419
Remove unnecessary dependency
...
Refs #1773 .
2019-08-22 10:04:38 +02:00
98464a8a33
Remove superfluous ForbiddenException
...
It has the same effect as the PermissionDeniedException, so let's
just use that.
Refs #1641 .
2019-08-22 00:06:26 +02:00
2b6535525b
When signups are prohibited, respond with HTTP 403
2019-08-21 23:48:24 +02:00
b60617b849
Move authentication check into assertCan() method
...
This will cause the right error (HTTP 401) to be thrown whenever
we're checking for a specific permission, but the user is not even
logged in. Authenticated users will still get HTTP 403.
2019-08-21 23:48:03 +02:00
0836d99e83
Remove unnecessary indirection
2019-08-21 00:06:32 +02:00
279c7df9b9
Document permission check methods
2019-08-21 00:06:31 +02:00
04bcf1eef6
Fix inconsistent status codes
...
HTTP 401 should be used when logging in (i.e. authenticating) would make
a difference; HTTP 403 is reserved for requests that fail because the
already authenticated user is not authorized (i.e. lacking permissions)
to do something.
2019-08-21 00:06:31 +02:00
70e98f810c
Travis: Remove deploy key
2019-08-21 00:06:16 +02:00
3851d805f7
Move to GitHub Actions ( #1853 )
2019-08-21 00:05:04 +02:00
085468382a
Error handling: Document another interface
2019-08-20 22:20:11 +02:00
7dbdd8c024
Rename method
2019-08-20 20:08:01 +02:00
ad25307e68
Error handling: Tweak Reporter interface
...
Because reporters are used for exceptions we were not able to handle, it
makes sense to simply pass the exception, not the "handled error".
2019-08-20 20:07:56 +02:00
6c454b8279
Error handling: Document classes and interfaces
2019-08-20 20:07:52 +02:00
9f15e9ba86
Error handling: Rename renderers to formatters
...
Refs #1641 .
2019-08-20 20:07:47 +02:00
41009dba74
Remove obsolete queue config
2019-08-19 22:33:32 +02:00
a045f8bef9
Queue support ( #1773 )
...
Implementation of clean queue handling, by default sync is used
2019-08-19 21:44:06 +02:00
689d767f82
Don't fail when extend.php doesn't return an array
...
Refs #1607 .
2019-08-16 12:29:31 +02:00
77fff9fde8
#1607 : Show more details when catching boot errors
2019-08-16 12:13:47 +02:00
c6c1ae32e6
Bubble up exception for invalid confirmation token
...
This way, the error handler can simply be amended to deal with this
exception type with a dedicated error message or page.
Refs #1337 .
Closes #1528 .
2019-08-14 19:47:56 +02:00
bdac88b573
Determine error view and message based on type
...
...not based on status code.
To simplify this logic, we now use the same error "type" both when
routes are not found and specific models are not found. One exception is
ours, one is from Laravel, but for the purposes of error handling they
should be treated the same.
Fixes flarum/core#1641 .
2019-08-14 19:47:56 +02:00
31ee65be93
Bundled output for commit 29df6b60be4bbf764baf3d6f818f9e91579c9326 [skip ci]
2019-08-14 06:41:45 +00:00
29df6b60be
Tweak translation keys, always use full keys
...
Makes them easier to grep when editing / removing.
Refs #1750 , #1788 .
2019-08-14 08:34:36 +02:00
1e6f175379
Extract real method
...
Refs #1750 , #1788 .
2019-08-14 08:34:14 +02:00
065ff3456f
Bundled output for commit 37e0a5579bdc8819b211408aec7f02909b8c86a0 [skip ci]
2019-08-13 21:02:10 +00:00
37e0a5579b
Improve feedback on user deletion
...
Fixes #1750 , #1777
2019-08-13 22:56:24 +02:00
cd9aa0096e
Merge pull request #1843 from flarum/fl/1641-exception-handling
...
Implement new error handling stack
2019-08-13 22:45:46 +02:00
d06493c61e
Support multiple error reporters
...
The error handling middleware now expects an array of reporters.
Extensions can register new reporters in the container like this:
use Flarum\Foundation\ErrorHandling\Reporter;
$container->tag(NewReporter::class, Reporter::class);
Note that this is just an implementation detail and will be hidden
behind an extender.
2019-08-10 11:04:12 +02:00
9f71e2c3cb
Remove old error handler, middleware and tests
2019-08-10 00:26:24 +02:00
81a8736ba9
API Client: Use new error handling mechanism
2019-08-10 00:26:24 +02:00
