Commit Graph

3573 Commits

Author SHA1 Message Date
b7355db2b7 Merge pull request #2154 from flarum/fl/2055-l58
Upgrade to Laravel 5.8
2020-05-12 15:20:01 +02:00
5dc9451c21 Fix notification query with DB prefix
This was fixed in https://github.com/laravel/framework/pull/28400.
See commit 7f1048352d09738ba6f4811ff84e6c4c2c9e4582.
2020-05-09 14:45:57 +02:00
220c8c66b0 Fix signature of HandleErrors middleware
In Laravel 5.8, the `Container::tagged()` method was changed to return
an iterator [1].

We only use the result for iteration, or, in this case, to pass a bunch
of "reporters" to the error handler middleware, therefore we need to
accept an iterable here.

[1]: https://laravel.com/docs/5.8/upgrade#container-generators
2020-05-08 23:30:17 +02:00
484933db7d Test setup: Do not use env() helper
Not needed, and not working without a full Laravel installation.
2020-05-08 23:30:17 +02:00
f6347dcc46 Update Laravel components to v5.8
First part of #2055.
2020-05-08 21:46:13 +02:00
107b4be726 Remove empty comment 2020-05-08 16:05:25 +02:00
93d4192b54 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-05-08 14:03:48 +00:00
ecdce44d55 Fix container configuration when not installed 2020-05-08 16:03:20 +02:00
a5e286e662 Drop MigrationServiceProvider 2020-05-08 12:04:24 +02:00
443949f7b9 Fix generate:migration command for extensions
Apparently, this code was from back when we had a special "extensions"
directory for Composer packages marked as Flarum extensions.

While we're at it, we now inject the Paths instance instead of using one
of the global helpers (which I am trying to get rid of).

Refs #2055.
2020-05-08 12:01:11 +02:00
4884aad2f0 Update beta.13 changelog 2020-05-08 11:35:46 +02:00
365eb15d29 Merge pull request #2142 from flarum/fl/2055-prepare-for-laravel-58
Split up Application and Container
2020-05-07 22:49:36 +02:00
85e2623622 Bundled output for commit 7d99727168d293218ba89ff126587f5f985b502f [skip ci] 2020-05-07 07:20:06 +00:00
7d99727168 commit version constant 2020-05-07 09:17:26 +02:00
84784c9839 Release v0.1.0-beta.13 2020-05-07 09:18:04 +02:00
a9470b463f Make two more tests compatible with PHPUnit 8 2020-05-07 09:18:04 +02:00
deb48bd173 Remove obsolete method 2020-05-07 09:18:04 +02:00
b38bd60362 Added simply confirmation popup for hiding / deleting posts (#2135) 2020-05-07 09:18:04 +02:00
260e7cd48f Inject new Paths class instead of Application
This (and similar work in other areas) will allow us to further
reduce the API surface of the Application class.

Separation of concerns etc.
2020-05-01 15:47:35 +02:00
41a56c4ad1 Split up Application and Container
- Stop trying to implement Laravel's Application contract, which
  has no value for us.
- Stop inheriting from the Container, injecting one works equally
  well and does not clutter up the interfaces.
- Inject the Paths collection instead of unwrapping it again, for
  better encapsulation.

This brings us one step closer toward upgrading our Laravel
components (#2055), because we no longer need to adopt the changes
to the Application contract.
2020-05-01 15:47:35 +02:00
d0ae2839f0 Extract a class to hold / determine paths 2020-05-01 15:24:20 +02:00
d31a747631 Bundled output for commit 526081bd06a2b22c32f0b6cddac37c57432cb6c2 [skip ci] 2020-05-01 09:53:55 +00:00
526081bd06 Update Webpack 2020-05-01 11:52:26 +02:00
cbdd3c5cc7 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-04-27 20:04:41 +00:00
7d1ef9d891 Remove a bunch of deprecated events
Use extenders instead!

Refs #1891.
2020-04-27 22:04:08 +02:00
7794546845 Model extender: Fix inheritance (#2132)
This ensures that default values, date attributes and relationships are properly inherited, when we have deeper model class hierarchies.

This also adds test cases to ensure that inheritance order is honored for relationship and default attribute extender. As there's no way to remove date attributes, the order of evaluation there doesn't matter.
2020-04-24 21:17:31 +02:00
c43cc874ee Model extender: Add failing test
We determined that child classes are not properly affected when
extending the parent classes.

Refs #2100.
2020-04-24 17:54:30 +02:00
33cf94c192 Fix test to match its description
Refs #2100.
2020-04-24 17:31:08 +02:00
036e519865 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-04-24 14:56:37 +00:00
9386c91af9 Tweak model extender tests
- Format code
- Reorder methods
- Test a different scenario to avoid the use of sleep()

Refs #2100.
2020-04-24 16:55:04 +02:00
8306cef963 Clean up model extender
- Remove unused private attributes
- Complete docblocks
- Add scalar type hints
- Format code
- Reorder methods

Refs #2100.
2020-04-24 16:33:08 +02:00
51ea326959 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-04-24 13:10:36 +00:00
15bed971e6 Add model extender (#2100)
This covers default attribute values, date attributes and custom relationships.
2020-04-24 15:10:24 +02:00
c896cd8696 npm audit fix 2020-04-24 14:30:16 +02:00
54ac83d0b6 Bundled output for commit 1592cd1013f2307e882267ebc179474164d3a0fd [skip ci] 2020-04-22 21:38:57 +00:00
1592cd1013 CI: Shorten the lint job name 2020-04-22 23:37:37 +02:00
6e8884f190 Implement hidden permission groups (#2129)
Only users that have the new `viewHiddenGroups` permissions will be able to see these groups.

You might want this when you want to give certain users special permissions, but don't want to make your authorization scheme public to regular users.

Co-authored-by: luceos <daniel+github@klabbers.email>
2020-04-21 17:49:53 +02:00
df8f73bd3d Statically access Flarum version everywhere
One less reason to inject the huge Application class.

Refs #2055.
2020-04-21 16:48:36 +02:00
3f0f89afb1 Use Container contract where easily possible
Less usages of the Application god-class simplifies splitting it up.

Refs #2055.
2020-04-21 16:48:06 +02:00
f0f301c5f4 Add compatiblity with Composer 2.0
- The structure of vendor/composer/installed.json will change.
- The same file will now contain the relative path to package locations.

References:
- https://github.com/composer/composer/blob/master/UPGRADE-2.0.md
- https://php.watch/articles/composer-2
2020-04-21 15:47:58 +02:00
3045bde167 Format code
- Early returns
- Comments
- Write variables only when needed

Refs #2020.
2020-04-19 16:53:52 +02:00
ee7a4627d8 Load only translations for enabled extensions from language packs (#2020)
fix #1837

Co-authored-by: Daniel Klabbers <daniel+git@klabbers.email>
2020-04-19 16:29:45 +02:00
b9fb92d49a Inline test class
Refs #1977.
2020-04-19 15:55:10 +02:00
b5accca957 Make AbstractPolicy compatible with both object and class as $model (#1977) 2020-04-19 15:52:59 +02:00
798a3486bf Bundled output for commit 89ef14faf13e4d661ee9f4f636a32578c73bf760 [skip ci] 2020-04-17 09:59:47 +00:00
89ef14faf1 Run prettier for all JS files 2020-04-17 11:57:55 +02:00
84cf938379 Merge pull request #2099 from flarum/fl/prettier
Install prettier for consistent JS styling
2020-04-17 11:20:52 +02:00
899cdfda4e CI: Run prettier to check for JS code formatting 2020-04-17 11:14:37 +02:00
72ed4faa83 Setup husky for automatic formatting before commit 2020-04-17 10:45:36 +02:00
64ad21e5da Add NPM shortcut for running prettier 2020-04-17 10:45:05 +02:00