|
|
a203469109
|
fix: Modal typings complicate inheritance (#3178)
|
2021-11-23 14:02:14 +01:00 |
|
|
|
9b9ca53b81
|
Add 'Close' & 'Back' aria-label attributes to buttons. (#3161)
* Add aria-label attributes to close buttons in nav, welcome hero, modal close.
* Replace title with aria-label in nav back button.
|
2021-11-11 15:55:46 -05:00 |
|
|
|
bac0e594ee
|
Add typechecks, typescript coverage GH action, fix many type errors (#3136)
|
2021-11-11 14:17:22 -05:00 |
|
|
|
7db2d0f697
|
chore: rewrite ModalManager and state to Typescript (#3007)
* Rewrite ModalManagerState into Typescript
- Fixes `attrs` parameter being marked as required
- Add `isModalOpen` method
* Rewrite ModalManager into Typescript
* Fix incorrect type
* Continue modal rewrite
* Update attr typings
* Fix correctly cast `this.constructor` calls
* Cast to bool
* Don't extend ModalAttrs by Record
* Prevent missing abstract methods in child Modals from bricking frontend
* Add missing `app` import
* Address review comment
Co-authored-by: David Sevilla Martin <6401250+datitisev@users.noreply.github.com>
Co-authored-by: David Sevilla Martin <6401250+datitisev@users.noreply.github.com>
|
2021-10-31 00:29:10 +02:00 |
|
