build: fix errors spotted by ineffassign linter

These were mostly caused by shadowing err and a good fraction of them
will have caused errors not to be propagated properly.
This commit is contained in:
Nick Craig-Wood
2018-05-04 15:19:50 +01:00
parent 790a8a9aed
commit cb5bd47e61
19 changed files with 37 additions and 22 deletions

View File

@ -187,10 +187,10 @@ func TestVFSStatParent(t *testing.T) {
assert.Equal(t, "/", node.Name())
assert.Equal(t, "not found", leaf)
node, leaf, err = vfs.StatParent("not found dir/not found")
_, _, err = vfs.StatParent("not found dir/not found")
assert.Equal(t, os.ErrNotExist, err)
node, leaf, err = vfs.StatParent("file1/under a file")
_, _, err = vfs.StatParent("file1/under a file")
assert.Equal(t, os.ErrExist, err)
}