Nick Craig-Wood 9c86759076 operations: fix partial name collisions for non --inplace copies ...

In this commit:

c63f1865f36058e1 operations: copy: generate stable partial suffix

We made the partial suffix for non inplace copies stable. This was a
hash based off the file fingerprint.

However, given a directory of files which have the same fingerprint
the partial suffix collides. On some backends (eg the local backend)
the fingerprint is just the size and modification time so files with
different contents can collide.

The effect of collisions was hash failures on copy when using
--transfers > 1. These copies invariably retried successfully which
probably explains why this bug hasn't been reported.

This fixes the problem by adding the file name to the hash.

It also makes sure the hash is always represented as 8 hex bytes for
consistency.

2025-02-01 11:20:15 +00:00

..

accounting

accounting: fix race stopping/starting the stats counter

2025-01-11 20:25:34 +00:00

asyncreader

Replace deprecated ioutil

2022-11-07 11:41:47 +00:00

cache

fs: fix confusing "didn't find section in config file" error

2025-01-15 16:32:59 +00:00

chunkedreader

chunkedreader: add --vfs-read-chunk-streams to parallel read chunks

2024-08-14 21:13:09 +01:00

chunksize

azureblob,b2,s3: fix chunksize calculations producing too many parts

2022-08-09 12:57:38 +01:00

config

lib/oauthutil: add support for OAuth client credential flow

2024-12-13 11:34:11 +00:00

dirtree

dirtree: fix performance with large directories of directories and --fast-list

2023-07-03 14:09:21 +01:00

driveletter

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

filter

build: update logging statements to make json log work - fixes #6038

2024-09-06 17:04:18 +01:00

fserrors

build: fix linting issues reported by running golangci-lint with different GOOS

2024-04-22 19:29:12 +02:00

fshttp

docs: fix typos found by codespell in docs and code comments

2025-01-16 10:39:01 +01:00

fspath

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

hash

build: update logging statements to make json log work - fixes #6038

2024-09-06 17:04:18 +01:00

list

fs/list: tweak directory listing assertions after allowing // names

2025-01-22 11:56:05 +00:00

log

build: update logging statements to make json log work - fixes #6038

2024-09-06 17:04:18 +01:00

logger

fs/logger: make the tests deterministic

2024-06-12 16:39:30 +01:00

march

accounting: fix global error acounting

2024-09-30 17:20:42 +01:00

object

docs: fix typos found by codespell in docs and code comments

2025-01-16 10:39:01 +01:00

operations

operations: fix partial name collisions for non --inplace copies

2025-02-01 11:20:15 +00:00

rc

fs: fix confusing "didn't find section in config file" error

2025-01-15 16:32:59 +00:00

sync

sync: fix cpu spinning when empty directory finding with leading slashes

2025-01-22 11:56:05 +00:00

walk

accounting: fix global error acounting

2024-09-30 17:20:42 +01:00

backend_config_test.go

fs: add --all to rclone config create/update to ask all the config questions #3455

2021-05-14 14:07:44 +01:00

backend_config.go

fs: fix typos found by codespell

2023-03-25 12:51:04 +01:00

bits_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

bits.go

fs: fix docs for Bits

2023-10-23 15:43:55 +01:00

bwtimetable_test.go

fs: Allow semicolons as well as spaces in --bwlimit timetable parsing - fixes #7595

2024-07-17 11:04:01 +01:00

bwtimetable.go

fs: Allow semicolons as well as spaces in --bwlimit timetable parsing - fixes #7595

2024-07-17 11:04:01 +01:00

config_list_test.go

fs: fix tests for *SepList

2018-08-21 10:58:59 +01:00

config_list.go

Make flags show up with their proper names, eg SizeSuffix rather than int

2019-02-07 11:57:26 +00:00

config_test.go

build: add lint ignore comment required for golangci-staticcheck in addition to stand-alone staticcheck

2023-03-26 14:28:15 +02:00

config.go

fs: make --links flag global and add new --local-links and --vfs-links flag

2024-12-13 12:43:20 +00:00

configmap.go

fs: fix the defaults overriding the actual config

2024-07-15 11:09:54 +01:00

countsuffix_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

countsuffix.go

build: fix gocritic lint issue dupbranchbody

2024-08-15 22:08:34 +01:00

cutoffmode_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

cutoffmode.go

fs: re-implement CutoffMode, LogLevel, TerminalColorMode with Enum

2023-10-03 15:14:24 +01:00

daemon_other.go

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

daemon_unix.go

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

deletemode.go

Break the fs package up into smaller parts.

2018-01-15 17:51:14 +00:00

dir_wrapper.go

combine: fix CopyDirMetadata error on upstream root

2024-03-07 11:09:07 +00:00

dir.go

fs: allow Metadata calls to be called with Directory or Object

2024-02-27 10:56:19 +00:00

direntries_test.go

build: fix up package paths after repo move

2019-07-28 18:47:38 +01:00

direntries.go

fs: Allow sync of a file and a directory with the same name

2019-06-09 15:57:05 +01:00

dump_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

dump.go

fs: implement --metadata-mapper to transform metatadata with a user supplied program

2023-11-18 17:49:35 +00:00

enum_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

enum.go

fs: re-implement CutoffMode, LogLevel, TerminalColorMode with Enum

2023-10-03 15:14:24 +01:00

features.go

fstest: add integration tests objects with // on bucket based backends #5858

2025-01-22 11:56:05 +00:00

fingerprint_test.go

mockfs: make it so it can be registered as an Fs

2023-04-28 14:31:05 +01:00

fingerprint.go

fs: add Fingerprint to detect changes in an object

2020-06-30 12:01:36 +01:00

fs_test.go

rc: add options/info call to enumerate options

2024-07-15 11:09:54 +01:00

fs.go

fs: Move link suffix to fs

2024-12-13 12:43:20 +00:00

log_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

log.go

docs: fix typos found by codespell in docs and code comments

2025-01-16 10:39:01 +01:00

metadata_mapper_code.go

build: remove build constraint syntax for go 1.16 and older

2024-04-18 16:53:55 +02:00

metadata_test.go

fs: implement --metadata-mapper to transform metatadata with a user supplied program

2023-11-18 17:49:35 +00:00

metadata.go

fs: allow Metadata calls to be called with Directory or Object

2024-02-27 10:56:19 +00:00

mimetype.go

dlna: set more correct mime type

2024-08-15 22:01:52 +01:00

mount_helper_test.go

rclone.mount: ignore _netdev mount argument - FIxes #5808

2022-05-12 20:27:13 +01:00

mount_helper.go

build: update logging statements to make json log work - fixes #6038

2024-09-06 17:04:18 +01:00

newfs_test.go

mount: fix mount failure on macOS with on the fly remote

2023-06-23 14:12:03 +01:00

newfs.go

fs: fix confusing "didn't find section in config file" error

2025-01-15 16:32:59 +00:00

open_options_test.go

fs: add --metadata-set flag to specify metadata for uploads

2022-06-29 14:29:36 +01:00

open_options.go

fs: fix Don't know how to set key "chunkSize" on upload errors in tests

2024-10-22 19:54:33 +01:00

override_dir_test.go

fs: add OverrideDirectory for overriding path of directory

2023-05-14 11:22:57 +01:00

override_dir.go

fs: add OverrideDirectory for overriding path of directory

2023-05-14 11:22:57 +01:00

override_test.go

fs: move operations.NewOverrideRemote to fs.NewOverrideRemote

2022-11-21 08:02:09 +00:00

override.go

fs: when creating new fs.OverrideRemotes don't layer overrides if not needed

2023-05-09 16:28:10 +01:00

pacer.go

pacer: fix b2 deadlock by defaulting max connections to unlimited

2023-10-01 12:30:26 +01:00

parseduration_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

parseduration.go

fs: improve JSON Unmarshalling for Duration

2024-03-13 18:08:59 +00:00

parsetime_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

parsetime.go

rc: fix output of Time values in options/get

2023-05-04 15:04:11 +01:00

registry.go

fs: fix setting stringArray config values from environment variables

2024-09-13 15:52:51 +01:00

sizesuffix_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

sizesuffix.go

build: fix gocritic lint issue dupbranchbody

2024-08-15 22:08:34 +01:00

terminalcolormode_test.go

fs: re-implement CutoffMode, LogLevel, TerminalColorMode with Enum

2023-10-03 15:14:24 +01:00

terminalcolormode.go

fs: re-implement CutoffMode, LogLevel, TerminalColorMode with Enum

2023-10-03 15:14:24 +01:00

tristate_test.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

tristate.go

fs: fix tristate conversion to JSON

2023-03-27 16:17:49 +01:00

types.go

fs: make Flagger and FlaggerNP interfaces public so we can test flags elsewhere

2024-07-15 11:09:54 +01:00

version.go

Configurable version suffix independent of version number

2022-05-17 12:10:01 +01:00

versioncheck.go

build: update to go1.24rc1 and make go1.22 the minimum required version

2025-01-14 12:13:14 +00:00

versionsuffix.go

Configurable version suffix independent of version number

2022-05-17 12:10:01 +01:00

versiontag.go

Start v1.70.0-DEV development

2025-01-12 16:31:12 +00:00