mirror of
https://github.com/rclone/rclone.git
synced 2025-04-24 13:14:13 +08:00
401cf81034
This commit modernizes Go usage. This was done with:
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
Then files needed to be `go fmt`ed and a few comments needed to be
restored.
The modernizations include replacing
- if/else conditional assignment by a call to the built-in min or max functions added in go1.21
- sort.Slice(x, func(i, j int) bool) { return s[i] < s[j] } by a call to slices.Sort(s), added in go1.21
- interface{} by the 'any' type added in go1.18
- append([]T(nil), s...) by slices.Clone(s) or slices.Concat(s), added in go1.21
- loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21
- []byte(fmt.Sprintf...) by fmt.Appendf(nil, ...), added in go1.19
- append(s[:i], s[i+1]...) by slices.Delete(s, i, i+1), added in go1.21
- a 3-clause for i := 0; i < n; i++ {} loop by for i := range n {}, added in go1.22
89 lines
2.3 KiB
Go
89 lines
2.3 KiB
Go
package rcserver
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"regexp"
|
|
"testing"
|
|
|
|
_ "github.com/rclone/rclone/backend/local"
|
|
"github.com/rclone/rclone/fs/accounting"
|
|
"github.com/rclone/rclone/fs/config/configfile"
|
|
"github.com/rclone/rclone/fs/rc"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Run a suite of tests
|
|
func testMetricsServer(t *testing.T, tests []testRun, opt *rc.Options) {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
configfile.Install()
|
|
rcServer, err := newMetricsServer(ctx, opt)
|
|
require.NoError(t, err)
|
|
testURL := rcServer.server.URLs()[0]
|
|
mux := rcServer.server.Router()
|
|
emulateCalls(t, tests, mux, testURL)
|
|
}
|
|
|
|
// return an enabled rc
|
|
func newMetricsTestOpt() rc.Options {
|
|
opt := rc.Opt
|
|
opt.MetricsHTTP.ListenAddr = []string{testBindAddress}
|
|
return opt
|
|
}
|
|
|
|
func TestMetrics(t *testing.T) {
|
|
stats := accounting.GlobalStats()
|
|
tests := makeMetricsTestCases(stats)
|
|
opt := newMetricsTestOpt()
|
|
testMetricsServer(t, tests, &opt)
|
|
|
|
// Test changing a couple options
|
|
stats.Bytes(500)
|
|
for range 30 {
|
|
require.NoError(t, stats.DeleteFile(context.Background(), 0))
|
|
}
|
|
stats.Errors(2)
|
|
stats.Bytes(324)
|
|
|
|
tests = makeMetricsTestCases(stats)
|
|
testMetricsServer(t, tests, &opt)
|
|
}
|
|
|
|
func makeMetricsTestCases(stats *accounting.StatsInfo) (tests []testRun) {
|
|
tests = []testRun{{
|
|
Name: "Bytes Transferred Metric",
|
|
URL: "metrics",
|
|
Method: "GET",
|
|
Status: http.StatusOK,
|
|
Contains: regexp.MustCompile(fmt.Sprintf("rclone_bytes_transferred_total %d", stats.GetBytes())),
|
|
}, {
|
|
Name: "Checked Files Metric",
|
|
URL: "metrics",
|
|
Method: "GET",
|
|
Status: http.StatusOK,
|
|
Contains: regexp.MustCompile(fmt.Sprintf("rclone_checked_files_total %d", stats.GetChecks())),
|
|
}, {
|
|
Name: "Errors Metric",
|
|
URL: "metrics",
|
|
Method: "GET",
|
|
Status: http.StatusOK,
|
|
Contains: regexp.MustCompile(fmt.Sprintf("rclone_errors_total %d", stats.GetErrors())),
|
|
}, {
|
|
Name: "Deleted Files Metric",
|
|
URL: "metrics",
|
|
Method: "GET",
|
|
Status: http.StatusOK,
|
|
Contains: regexp.MustCompile(fmt.Sprintf("rclone_files_deleted_total %d", stats.GetDeletes())),
|
|
}, {
|
|
Name: "Files Transferred Metric",
|
|
URL: "metrics",
|
|
Method: "GET",
|
|
Status: http.StatusOK,
|
|
Contains: regexp.MustCompile(fmt.Sprintf("rclone_files_transferred_total %d", stats.GetTransfers())),
|
|
},
|
|
}
|
|
return
|
|
}
|