From 02d28a8d8d242b2dc7b6cc98790727205a3d1798 Mon Sep 17 00:00:00 2001 From: Markus Makela Date: Thu, 3 Nov 2016 08:37:24 +0200 Subject: [PATCH] Always use format strings in dcb_printf The luafilter didn't use a format string with dcb_printf which can lead to unexpected results if the returned string contains printf special characters. --- server/modules/filter/luafilter/luafilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/modules/filter/luafilter/luafilter.c b/server/modules/filter/luafilter/luafilter.c index 137446f8c..dbfe5b2ae 100644 --- a/server/modules/filter/luafilter/luafilter.c +++ b/server/modules/filter/luafilter/luafilter.c @@ -570,7 +570,7 @@ static void diagnostic(FILTER *instance, void *fsession, DCB *dcb) lua_gettop(my_instance->global_lua_state); if (lua_isstring(my_instance->global_lua_state, -1)) { - dcb_printf(dcb, lua_tostring(my_instance->global_lua_state, -1)); + dcb_printf(dcb, "%s", lua_tostring(my_instance->global_lua_state, -1)); dcb_printf(dcb, "\n"); } }