hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1220: Make the parameters of the diagnostic entry points const

Browse Source 
The diagnostic entry points should not modify the state of the object
being diagnosed.
This commit is contained in:
Markus Mäkelä
2017-04-19 21:56:05 +03:00
committed by Markus Mäkelä
parent c17c451fb5
commit 076599ee5e
45 changed files with 78 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/maxscale/filter.hh
View File

@ -145,7 +145,7 @@ public:
/**
* Called for obtaining diagnostics about the filter session.
*/
json_t* diagnostics();
json_t* diagnostics() const;
protected:
FilterSession(MXS_SESSION* pSession);
@ -272,19 +272,19 @@ public:
return rv;
}
static json_t* diagnostics(MXS_FILTER* pInstance, MXS_FILTER_SESSION* pData)
static json_t* diagnostics(const MXS_FILTER* pInstance, const MXS_FILTER_SESSION* pData)
{
json_t* rval = NULL;
if (pData)
{
FilterSessionType* pFilterSession = static_cast<FilterSessionType*>(pData);
const FilterSessionType* pFilterSession = static_cast<const FilterSessionType*>(pData);
MXS_EXCEPTION_GUARD(rval = pFilterSession->diagnostics());
}
else
{
FilterType* pFilter = static_cast<FilterType*>(pInstance);
const FilterType* pFilter = static_cast<const FilterType*>(pInstance);
MXS_EXCEPTION_GUARD(rval = pFilter->diagnostics());
}