hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix writeq_low_water

Browse Source 
The value was never updated. Also amended the documentation to point out
that the parameter accepts size type values.
This commit is contained in:
Markus Mäkelä
2018-10-19 11:26:03 +03:00
parent 7d03bee648
commit 0862c724d8
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Documentation/Getting-Started/Configuration-Guide.md
View File

@ -722,7 +722,7 @@ than `0`, this configuration setting will not have an effect.
#### `writeq_high_water` #### `writeq_high_water`
High water mark for network write buffer. Controls when network traffic High water mark for network write buffer. Controls when network traffic
throtting is started. throtting is started. The parameter accepts size type values.
More specifically, if the client side write queue is above this value, it will More specifically, if the client side write queue is above this value, it will
block traffic coming from backend servers. If the backend side write queue is block traffic coming from backend servers. If the backend side write queue is
@ -736,8 +736,8 @@ throtting is enabled. By default, traffic throttling is disabled.
Low water mark for network write buffer. Once the traffic throttling is enabled, Low water mark for network write buffer. Once the traffic throttling is enabled,
it will only be disabled when the write queue is below `writeq_high_water`. The it will only be disabled when the write queue is below `writeq_high_water`. The
minimum allowed size is 512 bytes. `writeq_high_water` must always be greater parameter accepts size type values. The minimum allowed size is 512
than `writeq_low_water`. bytes. `writeq_high_water` must always be greater than `writeq_low_water`.
### REST API Configuration ### REST API Configuration

4
server/core/config.cc
View File

@ -2500,9 +2500,9 @@ static int handle_global_item(const char* name, const char* value)
} }
else if (strcmp(name, CN_WRITEQ_LOW_WATER) == 0) else if (strcmp(name, CN_WRITEQ_LOW_WATER) == 0)
{ {
if (!get_suffixed_size(value, &gateway.writeq_high_water)) if (!get_suffixed_size(value, &gateway.writeq_low_water))
{ {
MXS_ERROR("Invalid value for %s: %s", CN_WRITEQ_HIGH_WATER, value); MXS_ERROR("Invalid value for %s: %s", CN_WRITEQ_LOW_WATER, value);
return 0; return 0;
} }