hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1346: Make permission rules a class

Browse Source 
The default rule is of the type that always matches any query and the Rule
base class should reflect this.
This commit is contained in:
Markus Mäkelä
2017-08-31 09:51:06 +03:00
parent b7f922bf6d
commit 0d8284f82e
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/modules/filter/dbfwfilter/dbfwfilter.cc
View File

@ -292,7 +292,9 @@ struct Rule
virtual bool matches_query(GWBUF* buffer, char** msg) virtual bool matches_query(GWBUF* buffer, char** msg)
{ {
return false; *msg = create_error("Permission denied at this time.");
MXS_NOTICE("rule '%s': query denied at this time.", rule->name.c_str());
return true;
} }
virtual bool need_full_parsing(GWBUF* buffer) const virtual bool need_full_parsing(GWBUF* buffer) const
@ -2155,9 +2157,7 @@ bool rule_matches(FW_INSTANCE* my_instance,
break; break;
case RT_PERMISSION: case RT_PERMISSION:
matches = true; /** Handled in Rule::matches_query */
msg = create_error("Permission denied at this time.");
MXS_NOTICE("rule '%s': query denied at this time.", rule->name.c_str());
break; break;
case RT_COLUMN: case RT_COLUMN: