Rearrange libraries and build files.

This is the first change in an attempt to arrange the linking so that
more errors are detected at link-time.

- All files in server/core but for gateway.c are linked to one shared
  library called maxscale-common.
- The files log_manager/log_manager.cc and utils/skygw_utils.cc are
  built into maxscale-common as well.
- MaxScale itself consists now only of gateway.c and is linked with
  maxscale-common.
- All plugins link with maxscale-common.
- All executables link in addition with {EMBEDDED_LIB}.

After this change, the change (MXS-517) where query_classifier is the
only component that uses ${EMBEDDED_LIB} and the rest mysqlclient can
be made much cleaner.

After a few additional steps, all shared libraries can be linked with
the linker flags "-Wl,-z,defs", which directs the linker to resolve
all symbols. That will require that all shared libraries list all the
libraries they need, but will at the same time ensure that any
missing symbols are detected at link-time and not at run-time.

server/modules/filter/CMakeLists.txt

@@ -2,7 +2,7 @@ if(BUILD_RABBITMQ)
   if(RABBITMQ_FOUND)
     include_directories(${RABBITMQ_HEADERS})
     add_library(mqfilter SHARED mqfilter.c)
-    target_link_libraries(mqfilter query_classifier log_manager ${RABBITMQ_LIBRARIES})
+    target_link_libraries(mqfilter query_classifier maxscale-common ${RABBITMQ_LIBRARIES})
     add_dependencies(mqfilter pcre2)
     install(TARGETS mqfilter DESTINATION ${MAXSCALE_LIBDIR})
   else()
@@ -11,45 +11,45 @@ if(BUILD_RABBITMQ)
 endif()
 
 add_library(regexfilter SHARED regexfilter.c)
-target_link_libraries(regexfilter log_manager)
+target_link_libraries(regexfilter maxscale-common)
 add_dependencies(regexfilter pcre2)
 set_target_properties(regexfilter PROPERTIES VERSION "1.1.0")
 install(TARGETS regexfilter DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(testfilter SHARED testfilter.c)
-target_link_libraries(testfilter log_manager)
+target_link_libraries(testfilter maxscale-common)
 set_target_properties(testfilter PROPERTIES VERSION "1.0.0")
 install(TARGETS testfilter DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(qlafilter SHARED qlafilter.c)
-target_link_libraries(qlafilter log_manager)
+target_link_libraries(qlafilter maxscale-common)
 set_target_properties(qlafilter PROPERTIES VERSION "1.1.1")
 install(TARGETS qlafilter DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(tee SHARED tee.c)
-target_link_libraries(tee log_manager)
+target_link_libraries(tee maxscale-common)
 set_target_properties(tee PROPERTIES VERSION "1.0.0")
 install(TARGETS tee DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(topfilter SHARED topfilter.c)
-target_link_libraries(topfilter log_manager)
+target_link_libraries(topfilter maxscale-common)
 set_target_properties(topfilter PROPERTIES VERSION "1.0.1")
 install(TARGETS topfilter DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(dbfwfilter SHARED dbfwfilter.c)
-target_link_libraries(dbfwfilter log_manager query_classifier)
+target_link_libraries(dbfwfilter maxscale-common query_classifier)
 set_target_properties(dbfwfilter PROPERTIES VERSION "1.0.0")
 install(TARGETS dbfwfilter DESTINATION ${MAXSCALE_LIBDIR})
 
 add_library(namedserverfilter SHARED namedserverfilter.c)
-target_link_libraries(namedserverfilter log_manager)
+target_link_libraries(namedserverfilter maxscale-common)
 set_target_properties(namedserverfilter PROPERTIES VERSION "1.1.0")
 install(TARGETS namedserverfilter DESTINATION ${MAXSCALE_LIBDIR})
 
 
 if(BUILD_SLAVELAG)
   add_library(slavelag SHARED slavelag.c)
-  target_link_libraries(slavelag log_manager query_classifier)
+  target_link_libraries(slavelag maxscale-common query_classifier)
   set_target_properties(slavelag PROPERTIES VERSION "1.1.0")
   install(TARGETS slavelag DESTINATION ${MAXSCALE_LIBDIR})
 endif()
@@ -57,7 +57,7 @@ endif()
 if(BUILD_TOOLS)
   add_executable(ruleparser dbfwfilter.c)
   target_compile_definitions(ruleparser PUBLIC "BUILD_RULE_PARSER")
-  target_link_libraries(ruleparser  ${EMBEDDED_LIB} log_manager query_classifier fullcore)
+  target_link_libraries(ruleparser maxscale-common query_classifier)
   install(TARGETS ruleparser DESTINATION ${MAXSCALE_BINDIR})
 endif()
 

server/modules/filter/hint/CMakeLists.txt

@@ -1,4 +1,4 @@
 add_library(hintfilter SHARED hintfilter.c hintparser.c)
 set_target_properties(hintfilter PROPERTIES INSTALL_RPATH ${CMAKE_INSTALL_RPATH}:${MAXSCALE_LIBDIR} VERSION "1.0.0")
-target_link_libraries(hintfilter ssl log_manager utils)
+target_link_libraries(hintfilter maxscale-common)
 install(TARGETS hintfilter DESTINATION ${MAXSCALE_LIBDIR})

server/modules/filter/test/CMakeLists.txt

@@ -1,8 +1,8 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 add_executable(harness_ui harness_ui.c harness_common.c)
 add_executable(harness harness_util.c harness_common.c)
-target_link_libraries(harness_ui fullcore log_manager utils)
-target_link_libraries(harness fullcore)
+target_link_libraries(harness_ui maxscale-common)
+target_link_libraries(harness maxscale-common)
 execute_process(COMMAND ${CMAKE_COMMAND} -E copy ${ERRMSG} ${CMAKE_CURRENT_BINARY_DIR})
 execute_process(COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/harness.cnf ${CMAKE_CURRENT_BINARY_DIR})
 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/testdriver.sh ${CMAKE_CURRENT_BINARY_DIR}/testdriver.sh @ONLY)