From 237975ebcd06e6087dc1fe2482c5f3aa1c2cf277 Mon Sep 17 00:00:00 2001 From: MassimilianoPinto Date: Thu, 30 Oct 2014 17:16:59 +0100 Subject: [PATCH] Coverity 72692 Coverity 72692 --- server/core/hashtable.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/server/core/hashtable.c b/server/core/hashtable.c index 1aedbebe0..762869434 100644 --- a/server/core/hashtable.c +++ b/server/core/hashtable.c @@ -258,7 +258,9 @@ hashtable_add(HASHTABLE *table, void *key, void *value) /* check succesfull key copy */ if ( ptr->key == NULL) { + free(ptr); hashtable_write_unlock(table); + return 0; } @@ -269,9 +271,11 @@ hashtable_add(HASHTABLE *table, void *key, void *value) if ( ptr->value == NULL) { /* remove the key ! */ table->kfreefn(ptr->key); + free(ptr); /* value not copied, return */ hashtable_write_unlock(table); + return 0; } @@ -279,6 +283,7 @@ hashtable_add(HASHTABLE *table, void *key, void *value) table->entries[hashkey % table->hashsize] = ptr; } hashtable_write_unlock(table); + return 1; }