hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mysql_common.c:protocol_add_srv_command didn't check that protocol status was MYSQL_PROTOCOL_ACTIVE and wrote to freed memory.

Browse Source
This commit is contained in:
VilhoRaatikka
2014-08-14 17:23:46 +03:00
parent 15e3ef6950
commit 2393ac57e9
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/modules/protocol/mysql_backend.c
View File

@ -1006,7 +1006,8 @@ gw_backend_hangup(DCB *dcb)
&succp); &succp);
/** There are not required backends available, close session. */ /** There are not required backends available, close session. */
if (!succp) { if (!succp)
{
#if defined(SS_DEBUG) #if defined(SS_DEBUG)
LOGIF(LE, (skygw_log_write_flush( LOGIF(LE, (skygw_log_write_flush(
LOGFILE_ERROR, LOGFILE_ERROR,

5
server/modules/protocol/mysql_common.c
View File

@ -1712,6 +1712,10 @@ void protocol_add_srv_command(
spinlock_acquire(&p->protocol_lock); spinlock_acquire(&p->protocol_lock);
if (p->protocol_state != MYSQL_PROTOCOL_ACTIVE)
{
goto retblock;
}
/** this is the only server command in protocol */ /** this is the only server command in protocol */
if (p->protocol_command.scom_cmd == MYSQL_COM_UNDEFINED) if (p->protocol_command.scom_cmd == MYSQL_COM_UNDEFINED)
{ {
@ -1744,6 +1748,7 @@ void protocol_add_srv_command(
c = c->scom_next; c = c->scom_next;
} }
#endif #endif
retblock:
spinlock_release(&p->protocol_lock); spinlock_release(&p->protocol_lock);
} }