Added new parameter RW Split Router.max_slave_connections=[<int>|<int>%] which specifies the maximum number of slaves which read/write split router connects in each routing session.

Parameter it read from config file to CONFIG_CONTEXT's parameter list. It is qualified in service.c:service_set_slave_conn_limit and if qualified, the qualified integer value and the value type are copied to the CONFIG_PARAMETER structure.

This CONFIG_PARAMETER struct is cloned (=copied to different memory area) and linked to RW Split SERVICE struct.

When RW Split router_instance is created in readwritesplit.c:createInstance, the value is copied to (new) rwsplit_config_t structure from SERVICE's parameter list.

When new routing session is created in readwritesplit.c:newSession, the rwsplit_config_t structure is copied to ROUTER_CLIENT_SES struct and the actual max_nslaves value is calculated from the config value (if percentage is used).

Tests and many error handling branches are missing but functionality seems to be working.

server/core/service.c

@@ -34,6 +34,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <ctype.h>
+#include <errno.h>
 #include <session.h>
 #include <service.h>
 #include <server.h>
@@ -52,6 +54,11 @@ extern int lm_enabled_logfiles_bitmask;
 static SPINLOCK	service_spin = SPINLOCK_INIT;
 static SERVICE	*allServices = NULL;
 
+static void service_add_qualified_param(
+        SERVICE*          svc,
+        CONFIG_PARAMETER* param);
+
+
 /**
  * Allocate a new service for the gateway to support
  *
@@ -752,3 +759,95 @@ int service_refresh_users(SERVICE *service) {
 	else
 		return 1;
 }
+
+bool service_set_slave_conn_limit (
+        SERVICE*          service,
+        CONFIG_PARAMETER* param,
+        char*             valstr,
+        count_spec_t      count_spec)
+{
+        char* p;
+        int   valint;
+        bool  percent = false;
+        bool  succp;
+        
+        /**
+         * Find out whether the value is numeric and ends with '%' or '\0'
+         */
+        p = valstr;
+        
+        while(isdigit(*p)) p++;
+
+        errno = 0;
+        
+        if (p == valstr || (*p != '%' && *p != '\0'))
+        {
+                succp = false;
+        }
+        else if (*p == '%')
+        {
+                if (*(p+1) == '\0')
+                {
+                        *p = '\0';
+                        valint = (int) strtol(valstr, (char **)NULL, 10);
+                        
+                        if (valint == 0 && errno != 0)
+                        {
+                                succp = false;
+                        }
+                        else
+                        {
+                                succp   = true;
+                                config_set_qualified_param(param, (void *)&valint, PERCENT_TYPE);
+                        }
+                }
+                else
+                {
+                        succp = false;
+                }
+        }
+        else if (*p == '\0')
+        {
+                valint = (int) strtol(valstr, (char **)NULL, 10);
+                
+                if (valint == 0 && errno != 0)
+                {
+                        succp = false;
+                }
+                else
+                {
+                        succp = true;
+                        config_set_qualified_param(param, (void *)&valint, COUNT_TYPE);
+                }
+        }
+        
+        if (succp)
+        {
+                service_add_qualified_param(service, param); /*< add param to svc */
+        }
+        return succp;
+}
+
+/**
+ * Add qualified config parameter to SERVICE struct.
+ */
+static void service_add_qualified_param(
+        SERVICE*          svc,
+        CONFIG_PARAMETER* param)
+{
+        CONFIG_PARAMETER** p = &svc->svc_config_param;
+        
+        spinlock_acquire(&svc->spin);
+        
+        if ((*p) != NULL)
+        {
+                while ((*p)->next != NULL) *p = (*p)->next;
+                (*p)->next = config_clone_param(param);
+        }
+        else        
+        {
+                (*p) = config_clone_param(param);
+        }
+        (*p)->next = NULL;
+        spinlock_release(&svc->spin);
+}