hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log a message for every online change

Browse Source 
All changes made to the configuration should be traceable. This makes the
process of understanding the life-cycle of a specific MaxScale
installation easier.
This commit is contained in:
Markus Makela
2016-12-09 19:04:31 +02:00
parent 49aa23468d
commit 312cf69739
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
server/core/config_runtime.c
View File

@ -136,6 +136,8 @@ bool runtime_create_server(const char *name, const char *address, const char *po
if (server && server_serialize(server)) if (server && server_serialize(server))
{ {
MXS_NOTICE("Created server '%s' at %s:%u", server->unique_name,
server->name, server->port);
rval = true; rval = true;
} }
} }
@ -245,6 +247,7 @@ bool runtime_enable_server_ssl(SERVER *server, const char *key, const char *cert
if (server_serialize(server)) if (server_serialize(server))
{ {
MXS_NOTICE("Enabled SSL for server '%s'", server->unique_name);
rval = true; rval = true;
} }
} }
@ -283,6 +286,7 @@ bool runtime_alter_server(SERVER *server, char *key, char *value)
if (valid) if (valid)
{ {
server_serialize(server); server_serialize(server);
MXS_NOTICE("Updated server '%s': %s=%s", server->unique_name, key, value);
} }
spinlock_release(&crt_lock); spinlock_release(&crt_lock);
@ -381,9 +385,14 @@ bool runtime_alter_monitor(MONITOR *monitor, char *key, char *value)
monitorStart(monitor, monitor->parameters); monitorStart(monitor, monitor->parameters);
} }
if (valid && monitor->created_online) if (valid)
{ {
monitor_serialize(monitor); if (monitor->created_online)
{
monitor_serialize(monitor);
}
MXS_NOTICE("Updated monitor '%s': %s=%s", monitor->name, key, value);
} }
spinlock_release(&crt_lock); spinlock_release(&crt_lock);
@ -452,7 +461,7 @@ bool runtime_create_listener(SERVICE *service, const char *name, const char *add
if (listener && listener_serialize(listener) && serviceLaunchListener(service, listener)) if (listener && listener_serialize(listener) && serviceLaunchListener(service, listener))
{ {
MXS_NOTICE("Listener '%s' at %s:%s for service '%s' created", MXS_NOTICE("Created listener '%s' at %s:%s for service '%s'",
name, print_addr, port, service->name); name, print_addr, port, service->name);
} }
else else
@ -532,6 +541,7 @@ bool runtime_create_monitor(const char *name, const char *module)
if (monitor_serialize(monitor)) if (monitor_serialize(monitor))
{ {
MXS_NOTICE("Created monitor '%s'", name);
rval = true; rval = true;
} }
} }

5
server/core/server.c
View File

@ -829,7 +829,6 @@ server_update_credentials(SERVER *server, char *user, char *passwd)
if (user != NULL && passwd != NULL) if (user != NULL && passwd != NULL)
{ {
serverAddMonUser(server, user, passwd); serverAddMonUser(server, user, passwd);
MXS_NOTICE("Updated monitor credentials for server '%s'", server->name);
} }
} }
@ -997,8 +996,6 @@ server_update_address(SERVER *server, char *address)
spinlock_acquire(&server_spin); spinlock_acquire(&server_spin);
if (server && address) if (server && address)
{ {
MXS_NOTICE("Updated the address of server '%s' from '%s' to '%s'.",
server->unique_name, server->name, address);
strcpy(server->name, address); strcpy(server->name, address);
} }
spinlock_release(&server_spin); spinlock_release(&server_spin);
@ -1017,8 +1014,6 @@ server_update_port(SERVER *server, unsigned short port)
spinlock_acquire(&server_spin); spinlock_acquire(&server_spin);
if (server && port > 0) if (server && port > 0)
{ {
MXS_NOTICE("Updated the port of server '%s' from %d to %d.",
server->unique_name, server->port, port);
server->port = port; server->port = port;
} }
spinlock_release(&server_spin); spinlock_release(&server_spin);