hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2456: Test transaction replay cap

Browse Source 
Added a test that makes sure the transaction replay cap is respected. Also
improved the logging to show how many transaction replay attemps have been
done and to log if a replay is not done due to too many attempts.
This commit is contained in:
Markus Mäkelä
2019-05-02 10:12:11 +03:00
parent 26b2897280
commit 3dd9298b18
4 changed files with 127 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/modules/routing/readwritesplit/rwsplitsession.cc
View File

@ -885,6 +885,8 @@ bool RWSplitSession::start_trx_replay()
if (m_config.transaction_replay && m_can_replay_trx && m_num_trx_replays < m_config.trx_max_attempts)
{
++m_num_trx_replays;
if (!m_is_replay_active)
{
// This is the first time we're retrying this transaction, store it and the interrupted query
@ -910,7 +912,7 @@ bool RWSplitSession::start_trx_replay()
// Stash any interrupted queries while we replay the transaction
m_interrupted_query.reset(m_current_query.release());
MXS_INFO("Starting transaction replay");
MXS_INFO("Starting transaction replay %ld", m_num_trx_replays);
m_is_replay_active = true;
/**
@ -951,9 +953,14 @@ bool RWSplitSession::start_trx_replay()
"transaction had no statements and no query was interrupted");
}
++m_num_trx_replays;
rval = true;
}
else if (m_num_trx_replays >= m_config.trx_max_attempts)
{
mxb_assert(m_num_trx_replays == m_config.trx_max_attempts);
MXS_INFO("Transaction replay attempt cap of %ld exceeded, not attempting replay",
m_config.trx_max_attempts);
}
return rval;
}