hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Never reactivate monitors

Browse Source 
Reactivating monitors shouldn't be done as it's simpler to actually
destroy and create a new one. The performance of reactivation is
insignificant compared to the possible inconsistency problems it allows.
This commit is contained in:
Markus Mäkelä
2019-03-21 14:20:37 +02:00
parent 203bba0e1d
commit 40df519be4
3 changed files with 13 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
server/core/monitor.cc
View File

@ -680,27 +680,6 @@ Monitor* MonitorManager::find_monitor(const char* name)
return rval;
}
/**
* Find a destroyed monitor by name
*
* @param name The name of the monitor
* @return Pointer to the destroyed monitor or NULL if monitor is not found
*/
Monitor* MonitorManager::reactivate_monitor(const char* name, const char* module)
{
Monitor* rval = NULL;
this_unit.foreach_monitor([&rval, name, module](Monitor* monitor) {
if (strcmp(monitor->m_name, name) == 0 && (monitor->m_module == module))
{
mxb_assert(!monitor->m_active);
monitor->m_active = true;
rval = monitor;
}
return (rval == nullptr);
});
return rval;
}
/**
* Return a resultset that has the current set of monitors in it
*