MXS-1220: Add test for HttpParser

The test simulates various HTTP requests and checks that they are parsed
properly.

server/core/test/CMakeLists.txt

@@ -23,6 +23,7 @@ add_executable(testmaxscalepcre2 testmaxscalepcre2.cc)
 add_executable(testmodulecmd testmodulecmd.cc)
 add_executable(testconfig testconfig.cc)
 add_executable(trxboundaryparser_profile trxboundaryparser_profile.cc)
+add_executable(testhttp testhttp.cc)
 target_link_libraries(test_atomic maxscale-common)
 target_link_libraries(test_adminusers maxscale-common)
 target_link_libraries(test_buffer maxscale-common)
@@ -48,6 +49,7 @@ target_link_libraries(testmaxscalepcre2 maxscale-common)
 target_link_libraries(testmodulecmd maxscale-common)
 target_link_libraries(testconfig maxscale-common)
 target_link_libraries(trxboundaryparser_profile maxscale-common)
+target_link_libraries(testhttp maxscale-common)
 add_test(TestAtomic test_atomic)
 add_test(TestAdminUsers test_adminusers)
 add_test(TestBuffer test_buffer)
@@ -79,7 +81,7 @@ add_test(TestTrxCompare_Select test_trxcompare ${CMAKE_CURRENT_SOURCE_DIR}/../..
 add_test(TestTrxCompare_Set test_trxcompare ${CMAKE_CURRENT_SOURCE_DIR}/../../../query_classifier/test/set.test)
 add_test(TestTrxCompare_Update test_trxcompare ${CMAKE_CURRENT_SOURCE_DIR}/../../../query_classifier/test/update.test)
 add_test(TestTrxCompare_MaxScale test_trxcompare ${CMAKE_CURRENT_SOURCE_DIR}/../../../query_classifier/test/maxscale.test)
-
+add_test(TestHttp testhttp)
 
 # This test requires external dependencies and thus cannot be run
 # as a part of the core test set

server/core/test/testhttp.cc

@@ -0,0 +1,170 @@
+/*
+ * Copyright (c) 2016 MariaDB Corporation Ab
+ *
+ * Use of this software is governed by the Business Source License included
+ * in the LICENSE.TXT file and at www.mariadb.com/bsl11.
+ *
+ * Change Date: 2019-07-01
+ *
+ * On the date above, in accordance with the Business Source License, use
+ * of this software will be governed by version 2 or later of the General
+ * Public License.
+ */
+
+#include "../maxscale/httpparser.hh"
+
+#include <sstream>
+
+using std::stringstream;
+using std::string;
+
+#define TEST(a, b, ...) do{if (!(a)){printf(b "\n", ##__VA_ARGS__);return 1;}}while(false)
+
+const char* verbs_pass[] =
+{
+    "GET",
+    "PUT",
+    "POST",
+    "OPTIONS",
+    "PATCH",
+    NULL
+};
+
+const char* verbs_fail[] =
+{
+    "LOAD",
+    "STORE",
+    "PUBLISH",
+    "Something that's not a verb",
+    "⬠",
+    NULL
+};
+
+const char* paths_pass[] =
+{
+    "/",
+    "*",
+    "/test/",
+    "/test",
+    "/servers/list",
+    "/servers/list/",
+    "/?test=true",
+    "/test/?test=y",
+    "/?",
+    NULL
+};
+
+const char* paths_fail[] =
+{
+    "-strikethrough-",
+    "_underline_",
+    "*bold*",
+    "?",
+    NULL
+};
+
+const char* proto_pass[] =
+{
+    "HTTP/1.1",
+    NULL
+};
+
+const char* proto_fail[] =
+{
+    "HTTP/2.0",
+    "SMTP/0.0",
+    "CDC/1.0",
+    NULL
+};
+
+int test_basic()
+{
+    /** Test parts that should pass */
+    for (int i = 0; verbs_pass[i]; i++)
+    {
+        for (int j = 0; paths_pass[j]; j++)
+        {
+            for (int k = 0; proto_pass[k]; k++)
+            {
+                stringstream ss;
+                ss << verbs_pass[i] << " " << paths_pass[j] << " " << proto_pass[k] << "\r\n\r\n";
+                SHttpParser parser(HttpParser::parse(ss.str()));
+                TEST(parser.get() != NULL, "Valid HTTP request should be parsed: %s", ss.str().c_str());
+                TEST(parser->get_resource() == string(paths_pass[j]),
+                     "The request path '%s' should be correct: %s",
+                     paths_pass[j], parser->get_resource().c_str());
+            }
+        }
+    }
+
+    /** Test parts that should fail */
+    for (int i = 0; verbs_fail[i]; i++)
+    {
+        for (int j = 0; paths_fail[j]; j++)
+        {
+            for (int k = 0; proto_fail[k]; k++)
+            {
+                stringstream ss;
+                ss << verbs_fail[i] << " " << paths_fail[j] << " " << proto_fail[k] << "\r\n\r\n";
+                SHttpParser parser(HttpParser::parse(ss.str()));
+                TEST(parser.get() == NULL, "Invalid HTTP request should not be parsed: %s", ss.str().c_str());
+            }
+        }
+    }
+
+    return 0;
+}
+
+static struct
+{
+    const char* key;
+    const char* value;
+} headers_pass[] =
+{
+    {"Accept", "*/*"},
+    {"User-Agent", "curl/7.51.0"},
+    {"Authorization", "bWF4dXNlcjptYXhwd2QK"},
+    {"Content-Type", "application/json"},
+    {"Date", "1.1.2017 10:10:10"},
+    {"Host", "127.0.0.1:8080"},
+    {"If-Match", "bWF4dXNlcjptYXhwd2QK"},
+    {"If-Modified-Since", "Mon, 18 Nov 2013 08:14:29 -0600"},
+    {"If-None-Match", "bWF4dXNlcjptYXhwd2QK"},
+    {"If-Unmodified-Since", "Mon, 18 Nov 2013 08:14:29 -0600"},
+    {"X-HTTP-Method-Override", "PATCH"},
+    {"Allow", "GET, PATCH, PUT"},
+    {"Accept-Patch", "application/json-patch"},
+    {"Date", "Mon, 18 Nov 2013 08:14:29 -0600"},
+    {"ETag", "bWF4dXNlcjptYXhwd2QK"},
+    {"Last-Modified", "Mon, 18 Nov 2013 08:14:29 -0600"},
+    {"Location", "/servers/server1"},
+    {"WWW-Authenticate", "Basic"},
+    {0}
+};
+
+int test_headers()
+{
+    for (int i = 0; headers_pass[i].key; i++)
+    {
+        stringstream ss;
+        ss <<  "GET / HTTP/1.1\r\n" << headers_pass[i].key << ": "
+            << headers_pass[i].value <<"\r\n\r\n";
+        SHttpParser parser(HttpParser::parse(ss.str()));
+        TEST(parser.get() != NULL, "Valid HTTP request should be parsed: %s", ss.str().c_str());
+        TEST(parser->get_header(headers_pass[i].key).length() > 0, "Header should be found");
+        TEST(parser->get_header(headers_pass[i].key) == string(headers_pass[i].value),
+             "Header value should be correct: %s", parser->get_header(headers_pass[i].key).c_str());
+    }
+
+    return 0;
+}
+
+int main(int argc, char** argv)
+{
+    int rc = 0;
+
+    rc += test_basic();
+    rc += test_headers();
+
+    return rc;
+}