hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Event notification to slaves: code review

Browse Source 
Event notification to slaves: code review update
This commit is contained in:
MassimilianoPinto
2016-08-24 17:55:42 +02:00
parent 3e336323e8
commit 47317e2401
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
server/modules/routing/binlog/blr_master.c
View File

@ -111,7 +111,7 @@ extern bool blr_notify_waiting_slave(ROUTER_SLAVE *slave);
static int keepalive = 1; static int keepalive = 1;
/** Transactio-Safety feature */ /** Transaction-Safety feature */
typedef enum typedef enum
{ {
BLRM_NO_TRANSACTION, /*< No transaction */ BLRM_NO_TRANSACTION, /*< No transaction */
@ -2733,29 +2733,24 @@ void blr_notify_all_slaves(ROUTER_INSTANCE *router)
{ {
ROUTER_SLAVE *slave; ROUTER_SLAVE *slave;
int notified = 0; int notified = 0;
spinlock_acquire(&router->lock); spinlock_acquire(&router->lock);
slave = router->slaves; slave = router->slaves;
while (slave) while (slave)
{ {
if (slave->state != BLRS_DUMPING)
{
slave = slave->next;
continue;
}
/* Notify a slave that has CS_WAIT_DATA bit set */ /* Notify a slave that has CS_WAIT_DATA bit set */
if (blr_notify_waiting_slave(slave)) if (slave->state == BLRS_DUMPING &&
blr_notify_waiting_slave(slave))
{ {
notified++; notified++;
} }
slave = slave->next; slave = slave->next;
} }
spinlock_release(&router->lock); spinlock_release(&router->lock);
if (notified > 0) if (notified > 0)
{ {
MXS_BEBUG("Notified %d slaves about new data.", notified); MXS_DEBUG("Notified %d slaves about new data.", notified);
} }
} }