hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-1220: Make HTTP request handler parameters const

Browse Source 
The HttpRequest can be const as the request itself will not be modified.
This commit is contained in:
Markus Mäkelä
2017-04-20 19:29:34 +03:00
committed by Markus Mäkelä
parent 043ed95bdf
commit 47d819b008
2 changed files with 37 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/core/maxscale/resource.hh
View File

@ -29,7 +29,7 @@
#include "filter.h"
#include "session.h"
typedef HttpResponse (*ResourceCallback)(HttpRequest& request);
typedef HttpResponse (*ResourceCallback)(const HttpRequest& request);
class Resource
{
@ -47,7 +47,7 @@ public:
*
* @return True if this request matches this resource
*/
bool match(HttpRequest& request);
bool match(const HttpRequest& request) const;
/**
* @brief Handle a HTTP request
@ -56,11 +56,11 @@ public:
*
* @return Response to the request
*/
HttpResponse call(HttpRequest& request);
HttpResponse call(const HttpRequest& request) const;
private:
bool matching_variable_path(const std::string& path, const std::string& target);
bool matching_variable_path(const std::string& path, const std::string& target) const;
ResourceCallback m_cb; /**< Resource handler callback */
std::deque<std::string> m_path; /**< Path components */
@ -73,4 +73,4 @@ private:
*
* @return Response to request
*/
HttpResponse resource_handle_request(HttpRequest& request);
HttpResponse resource_handle_request(const HttpRequest& request);