MXS-1734 Remove command line flag retain-last-statements

From a practical perspective it makes no relevant difference
whether you have to add an entry to the config file and restart
maxscale or if you have to restart maxscale and provide a specific
command line, so better to provide just either possiblity.

More important would be to provide a way for turning this feature
on and off at runtime.
This commit is contained in:
Johan Wikman 2018-03-26 10:49:16 +03:00
parent 3d45d452eb
commit 4b282920ae

View File

@ -192,7 +192,6 @@ static void enable_module_unloading(const char* arg);
static void enable_statement_logging(const char* arg);
static void disable_statement_logging(const char* arg);
static void redirect_output_to_file(const char* arg);
static void retain_last_statements(const char* arg);
static bool user_is_acceptable(const char* specified_user);
static bool init_sqlite3();
@ -229,11 +228,6 @@ const DEBUG_ARGUMENT debug_arguments[] =
"disable-statement-logging", disable_statement_logging,
"disable the logging of SQL statements sent by MaxScale to the servers"
},
{
"retain-last-statements", retain_last_statements,
"retain the specified number of client statements\n"
SPACER "allows statements to be logged in problem situations"
},
{NULL, NULL, NULL}
};
@ -3212,18 +3206,6 @@ static void disable_statement_logging(const char* arg)
mxs_mysql_set_log_statements(false);
}
static void retain_last_statements(const char* arg)
{
int n = atoi(arg);
if (n < 0)
{
n = 0;
}
session_set_retain_last_statements(n);
}
static void redirect_output_to_file(const char* arg)
{
if (arg)