hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protected temporarily with spinlock gethostbyname which is not thread safe. This should be changed permanently so that gethostbyname is replaced with getaddrinfo.

Browse Source
This commit is contained in:
vraatikka
2013-09-05 19:42:59 +03:00
parent 8f98ae4751
commit 4f8057034a
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/core/gw_utils.c
View File

@ -36,6 +36,8 @@
#include <dcb.h> #include <dcb.h>
#include <session.h> #include <session.h>
SPINLOCK tmplock = SPINLOCK_INIT;
/** /**
* Set IP address in socket structure in_addr * Set IP address in socket structure in_addr
* *
@ -44,7 +46,12 @@
*/ */
void void
setipaddress(struct in_addr *a, char *p) { setipaddress(struct in_addr *a, char *p) {
struct hostent *h = gethostbyname(p); struct hostent *h;
spinlock_acquire(&tmplock);
h = gethostbyname(p);
spinlock_release(&tmplock);
if (h == NULL) { if (h == NULL) {
if ((a->s_addr = inet_addr(p)) == -1) { if ((a->s_addr = inet_addr(p)) == -1) {
fprintf(stderr, "unknown or invalid address [%s]\n", p); fprintf(stderr, "unknown or invalid address [%s]\n", p);