hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Readwritesplit: Graceful maintenance mode

Browse Source 
By allowing transactions to the master to end even if the server is in
maintenance mode makes it possible to terminate connections at a known
point. This helps prevent interrupted transactions which can help reduce
errors that are visible to the clients.
This commit is contained in:
Markus Mäkelä
2019-04-02 10:18:33 +03:00
parent 319d9fa1c5
commit 5242cd5ebf
4 changed files with 33 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
server/modules/routing/readwritesplit/rwsplitsession.cc
View File

@ -541,7 +541,7 @@ void RWSplitSession::close_stale_connections()
{
auto current_rank = get_current_rank();
for (auto& backend : m_backends)
for (auto& backend : m_raw_backends)
{
if (backend->in_use())
{
@ -549,8 +549,17 @@ void RWSplitSession::close_stale_connections()
if (!server->is_usable())
{
MXS_INFO("Discarding connection to '%s': Server is in maintenance", backend->name());
backend->close();
if (backend == m_current_master
&& can_continue_using_master(m_current_master)
&& !session_trx_is_ending(m_client->session))
{
MXS_INFO("Keeping connection to '%s' open until transaction ends", backend->name());
}
else
{
MXS_INFO("Discarding connection to '%s': Server is in maintenance", backend->name());
backend->close();
}
}
else if (server->rank() != current_rank)
{