hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qc_sqlite: Remove leak

Browse Source 
Previously a query like e.g.

    delete t11.*, t12.* from t11,t12 where t11.a = t12.a;

would cause a leak. The code for freeing that memory was present
but commented out because it used to cause a crash.

Now no crash appears, so it would seem that the crash was caused
by something else that no longer is present.
This commit is contained in:
Johan Wikman
2016-09-23 11:26:48 +03:00
parent 049f823d37
commit 542666ed16
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
query_classifier/qc_sqlite/qc_sqlite.c
View File

@ -1185,10 +1185,8 @@ void mxs_sqlite3DeleteFrom(Parse* pParse, SrcList* pTabList, Expr* pWhere, SrcLi
update_affected_fields(info, 0, pWhere, QC_TOKEN_MIDDLE, 0);
}
//TODO: Figure out why the following statements, causes a crash
//TODO: long down the road.
//TODO: exposed_sqlite3SrcListDelete(pParse->db, pTabList);
//TODO: exposed_sqlite3ExprDelete(pParse->db, pWhere);
exposed_sqlite3ExprDelete(pParse->db, pWhere);
exposed_sqlite3SrcListDelete(pParse->db, pTabList);
exposed_sqlite3SrcListDelete(pParse->db, pUsing);
}