From 59b587462a58bfaa25c72ab22b55de127c507e96 Mon Sep 17 00:00:00 2001 From: Markus Makela Date: Thu, 13 Nov 2014 09:09:11 +0200 Subject: [PATCH] Fix to Coverity defects 72714 75940 75941 --- server/modules/filter/qlafilter.c | 2 +- server/modules/filter/tee.c | 3 ++- server/modules/protocol/httpd.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/modules/filter/qlafilter.c b/server/modules/filter/qlafilter.c index 0f669b060..2f25ba1fb 100644 --- a/server/modules/filter/qlafilter.c +++ b/server/modules/filter/qlafilter.c @@ -398,7 +398,7 @@ routeQuery(FILTER *instance, void *session, GWBUF *queue) QLA_INSTANCE *my_instance = (QLA_INSTANCE *)instance; QLA_SESSION *my_session = (QLA_SESSION *)session; char *ptr; -int length; +int length = 0; struct tm t; struct timeval tv; diff --git a/server/modules/filter/tee.c b/server/modules/filter/tee.c index 94dc29ea0..43f7075c5 100644 --- a/server/modules/filter/tee.c +++ b/server/modules/filter/tee.c @@ -415,8 +415,9 @@ GWBUF *clone = NULL; modutil_MySQL_Query(queue, &dummy, &length, &residual); clone = gwbuf_clone(queue); my_session->residual = residual; - free(ptr); + } + free(ptr); } /* Pass the query downstream */ diff --git a/server/modules/protocol/httpd.c b/server/modules/protocol/httpd.c index ca0022284..175e0ad12 100644 --- a/server/modules/protocol/httpd.c +++ b/server/modules/protocol/httpd.c @@ -172,7 +172,7 @@ HTTPD_session *client_data = NULL; j++; } - while (!ISspace(buf[j]) && (i < sizeof(url) - 1) && (j < sizeof(buf))) { + while (!ISspace(buf[j]) && (i < sizeof(url) - 1) && (j < sizeof(buf) - 1)) { url[i] = buf[j]; i++; j++; }