MXS-1366: Validate closed connections before pooling them

When a session is being closed in a controlled manner, i.e. a COM_QUIT is
received from the client, it is possible to deduce from this fact that the
backend connections are very likely to be idle. This can be used as an
additional qualification that must be met by all connections before they
can be candidates for connection pooling.

This assumption will not hold with batched and asynchronous queries. In
this case it is possible that the COM_QUIT is received from the client
before even the first result from the backend is read. For this to work,
the protocol module would need to track the number and state of expected
responses.
This commit is contained in:
Markus Mäkelä
2017-08-21 10:31:07 +03:00
parent b56594470b
commit 5b1f8afcd9
4 changed files with 42 additions and 0 deletions

View File

@ -112,6 +112,7 @@ session_alloc(SERVICE *service, DCB *client_dcb)
session->stats.connect = time(0);
session->stmt.buffer = NULL;
session->stmt.target = NULL;
session->qualifies_for_pooling = false;
/*<
* Associate the session to the client DCB and set the reference count on
* the session to indicate that there is a single reference to the
@ -947,3 +948,14 @@ void session_clear_stmt(MXS_SESSION *session)
session->stmt.buffer = NULL;
session->stmt.target = NULL;
}
void session_qualify_for_pool(MXS_SESSION* session)
{
session->qualifies_for_pooling = true;
}
bool session_valid_for_pool(const MXS_SESSION* session)
{
ss_dassert(session->state != SESSION_STATE_DUMMY);
return session->qualifies_for_pooling;
}