hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing maxctrl test cases

Browse Source 
Code coverage revealed that some parts of the code could be easily
tested. Added these missing test cases and removed some dead code.
This commit is contained in:
Markus Mäkelä
2020-03-05 10:16:17 +02:00
parent 68c070c2c4
commit 5b45796da4
7 changed files with 111 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
maxctrl/lib/create.js
View File

@ -171,10 +171,8 @@ exports.builder = function(yargs) {
var err = false;
if (argv.params) {
err = validateParams(argv, argv.params)
monitor.data.attributes.parameters = argv.params.reduce(to_obj, {})
}
err = validateParams(argv, argv.params)
monitor.data.attributes.parameters = argv.params.reduce(to_obj, {})
if (argv.servers) {
for (i = 0; i < argv.servers.length; i++) {
@ -265,14 +263,12 @@ exports.builder = function(yargs) {
}
}
if (argv.params) {
var err = validateParams(argv, argv.params)
if (err) {
return Promise.reject(err)
}
filter.data.attributes.parameters = argv.params.reduce(to_obj, {})
var err = validateParams(argv, argv.params)
if (err) {
return Promise.reject(err)
}
filter.data.attributes.parameters = argv.params.reduce(to_obj, {})
return doRequest(host, 'filters', null, {method: 'POST', body: filter})
})