hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove support for TrxBoundaryMatcher

Browse Source 
For the general case, regex matching simply will not do. The
regex becomes so hairy so it turns write-only, i.e. unmaintainable.
Regex matching is also slower than a handwritten custom parser.
This commit is contained in:
Johan Wikman
2017-03-15 10:34:56 +02:00
parent c235e181ce
commit 5e39268e37
6 changed files with 11 additions and 483 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/core/test/testtrxtracking.cc
View File

@ -27,7 +27,6 @@ enum test_target_t
{
TEST_PARSER = 0x1,
TEST_QC = 0x2,
TEST_REGEX = 0x4,
TEST_ALL = (TEST_PARSER | TEST_QC)
};
@ -54,11 +53,6 @@ uint32_t get_qc_trx_type_mask(GWBUF* pBuf)
return qc_get_trx_type_mask_using(pBuf, QC_TRX_PARSE_USING_QC);
}
uint32_t get_regex_trx_type_mask(GWBUF* pBuf)
{
return qc_get_trx_type_mask_using(pBuf, QC_TRX_PARSE_USING_REGEX);
}
uint32_t get_parser_trx_type_mask(GWBUF* pBuf)
{
return qc_get_trx_type_mask_using(pBuf, QC_TRX_PARSE_USING_PARSER);
@ -376,7 +370,7 @@ int main(int argc, char* argv[])
bool dont_bail_out = false;
int c;
while ((c = getopt(argc, argv, "dpqr")) != -1)
while ((c = getopt(argc, argv, "dpq")) != -1)
{
switch (c)
{
@ -390,11 +384,6 @@ int main(int argc, char* argv[])
test_target = TEST_QC;
break;
case 'r':
test_all = false;
test_target = TEST_REGEX;
break;
case 'd':
dont_bail_out = true;
break;
@ -436,17 +425,6 @@ int main(int argc, char* argv[])
cout << endl;
}
if (test_target & TEST_REGEX)
{
cout << "Regex" << endl;
cout << "=====" << endl;
if (!test(get_regex_trx_type_mask, dont_bail_out))
{
rc = EXIT_FAILURE;
}
cout << endl;
}
if (test_target & TEST_PARSER)
{
cout << "Parser" << endl;