MXS-1300: Return a rejected promise for unknown commands

When an unknow command is executed, the core should return a rejected
promise.

maxctrl/lib/alter.js

@@ -44,7 +44,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: alter <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help alter` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help alter` for a list of commands.')
+            })
         })
 }

maxctrl/lib/call.js

@@ -40,7 +40,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: call <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help call` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help call` for a list of commands.')
+            })
         })
 }

maxctrl/lib/clear.js

@@ -25,7 +25,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: clear <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help clear` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help clear` for a list of commands.')
+            })
         })
 }

maxctrl/lib/common.js

@@ -44,6 +44,9 @@ module.exports = function() {
                 })
 
                 return Promise.all(promises)
+                    .catch(function(err) {
+                        argv.reject()
+                    })
             }, function(err) {
                 // One of the HTTP request pings to the cluster failed, log the error
                 logError(JSON.stringify(err.error, null, 4))
@@ -209,7 +212,7 @@ module.exports = function() {
 
     this.error = function(err) {
         logger.log(colors.red('Error:'), err)
-        this.argv.reject()
+        return Promise.reject()
     }
 }
 

maxctrl/lib/create.js

@@ -193,7 +193,9 @@ exports.builder = function(yargs) {
 
         .usage('Usage: create <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help create` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help create` for a list of commands.')
+            })
         })
 }

maxctrl/lib/destroy.js

@@ -39,7 +39,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: destroy <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help destroy` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help destroy` for a list of commands.')
+            })
         })
 }

maxctrl/lib/disable.js

@@ -31,8 +31,7 @@ exports.builder = function(yargs) {
                 })
             } else {
                 maxctrl(argv, function() {
-                    error('Invalid log priority: ' + argv.log)
+                    return error('Invalid log priority: ' + argv.log)
-                    return Promise.reject()
                 })
             }
         })
@@ -43,7 +42,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: disable <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help disable` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help disable` for a list of commands.')
+            })
         })
 }

maxctrl/lib/enable.js

@@ -31,8 +31,7 @@ exports.builder = function(yargs) {
                 })
             } else {
                 maxctrl(argv, function() {
-                    error('Invalid log priority: ' + argv.log)
+                    return error('Invalid log priority: ' + argv.log)
-                    return Promise.reject()
                 })
             }
         })
@@ -49,7 +48,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: enable <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help enable` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help enable` for a list of commands.')
+            })
         })
 }

maxctrl/lib/link.js

@@ -43,7 +43,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: link <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help link` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help link` for a list of commands.')
+            })
         })
 }

maxctrl/lib/list.js

@@ -103,7 +103,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: list <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help list` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help list` for a list of commands.')
+            })
         })
 }

maxctrl/lib/rotate.js

@@ -24,7 +24,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: rotate <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help rotate` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help rotate` for a list of commands.')
+            })
         })
 }

maxctrl/lib/set.js

@@ -25,7 +25,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: set <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help set` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help set` for a list of commands.')
+            })
         })
 }

maxctrl/lib/show.js

@@ -128,7 +128,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: show <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help show` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help show` for a list of commands.')
+            })
         })
 }

maxctrl/lib/start.js

@@ -29,7 +29,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: start <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help start` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help start` for a list of commands.')
+            })
         })
 }

maxctrl/lib/stop.js

@@ -29,7 +29,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: stop <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help stop` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help stop` for a list of commands.')
+            })
         })
 }

maxctrl/lib/unlink.js

@@ -43,7 +43,9 @@ exports.builder = function(yargs) {
         })
         .usage('Usage: unlink <command>')
         .help()
-        .command('*', 'the default command', {}, () => {
+        .command('*', 'the default command', {}, function(argv) {
-            logger.log('Unknown command. See output of `help unlink` for a list of commands.')
+            maxctrl(argv, function(host) {
+                return error('Unknown command. See output of `help unlink` for a list of commands.')
+            })
         })
 }