hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary locking

Browse Source 
The lock didn't really protect anything but since it was not explicitly
initialized, it caused a hang.
This commit is contained in:
Markus Mäkelä
2018-05-22 15:22:29 +03:00
parent 3fce61a615
commit 6159f863ce
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/modules/routing/avrorouter/avro_client.cc
View File

@ -767,13 +767,11 @@ static bool avro_client_stream_data(AvroSession *client)
bool ok = true;
spinlock_acquire(&client->file_lock);
if (client->file_handle == NULL &&
(client->file_handle = maxavro_file_open(filename)) == NULL)
{
ok = false;
}
spinlock_release(&client->file_lock);
if (ok)
{
@ -909,7 +907,6 @@ static void rotate_avro_file(AvroSession *client, char *fullname)
client->avro_binfile[len] = 0;
client->last_sent_pos = 0;
spinlock_acquire(&client->file_lock);
maxavro_file_close(client->file_handle);
if ((client->file_handle = maxavro_file_open(fullname)) == NULL)
@ -921,8 +918,6 @@ static void rotate_avro_file(AvroSession *client, char *fullname)
MXS_INFO("Rotated '%s'@'%s' to file: %s", client->dcb->user,
client->dcb->remote, fullname);
}
spinlock_release(&client->file_lock);
}
/**