hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2011 Enforce gtid based replication

Browse Source 
If secondary masters are defined, MASTER_USE_GTID=Slave_pos must
be specified for the default master.

If MASTER_USE_GTID is specified, only Slave_pos is allowed as
value.
This commit is contained in:
Johan Wikman
2018-09-04 12:55:07 +03:00
parent f5b73cf106
commit 65d355c7d7
1 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
server/modules/routing/binlogrouter/blr_slave.cc
View File

@ -4540,6 +4540,21 @@ int blr_handle_change_master(ROUTER_INSTANCE* router,
return -1; return -1;
} }
if (index != 0)
{
string use_gtid = router->configs[0].use_mariadb10_gtid;
if (use_gtid.empty() || (strcasecmp(use_gtid.c_str(), "slave_pos") != 0))
{
static const char MESSAGE[] =
"Secondary masters can only be used in conjunction with GTID based replication. "
"Specify MASTER_USE_GTID=Slave_pos for the default master connection.";
mxb_assert(sizeof(MESSAGE) <= BINLOG_ERROR_MSG_LEN);
strcpy(error, MESSAGE);
return -1;
}
}
std::vector<char> cmd_string(command, command + strlen(command) + 1); // Include the NULL std::vector<char> cmd_string(command, command + strlen(command) + 1); // Include the NULL
/* Parse SQL command and populate the change_master struct */ /* Parse SQL command and populate the change_master struct */
@ -4572,6 +4587,17 @@ int blr_handle_change_master(ROUTER_INSTANCE* router,
return -1; return -1;
} }
string use_gtid = options.use_mariadb10_gtid;
if (!use_gtid.empty() && (strcasecmp(use_gtid.c_str(), "slave_pos") != 0))
{
static const char MESSAGE[] =
"Only MASTER_USE_GTID=Slave_pos is allowed.";
mxb_assert(sizeof(MESSAGE) <= BINLOG_ERROR_MSG_LEN);
strcpy(error, MESSAGE);
return -1;
}
ChangeMasterConfig config; ChangeMasterConfig config;
if (!options.validate(router, error, &config)) if (!options.validate(router, error, &config))
{ {