From 6aab4ed41693d3b24a21c3d239a5a3e5735656a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20M=C3=A4kel=C3=A4?= Date: Wed, 4 Mar 2020 08:17:18 +0200 Subject: [PATCH] MXS-2893: Fix parameter validation The code assumed all parameters were string values. Encasing the code in a try-catch block solves it. --- maxctrl/lib/create.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/maxctrl/lib/create.js b/maxctrl/lib/create.js index bf43b6afb..d3b73ef2a 100644 --- a/maxctrl/lib/create.js +++ b/maxctrl/lib/create.js @@ -22,8 +22,12 @@ function to_obj(obj, value) { function validateParams(argv, params) { var rval = null; params.forEach((value) => { - var kv = value.split('=') - if (!kv || kv.length != 2) { + try { + var kv = value.split('=') + if (!kv || kv.length != 2) { + rval = 'Not a key-value parameter: ' + value + } + } catch (err) { rval = 'Not a key-value parameter: ' + value } })