hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to bug 680: http://bugs.mariadb.com/show_bug.cgi?id=680

Browse Source 
service.h:Added the 'serviceStartFailed' function which tries to start services with successfully started routers but no successfully started listeners.
mysql_mon.c:Added a call to ServiceStartFailed when servers come available.
This commit is contained in:
Markus Makela 2015-01-05 13:28:27 +02:00
parent e27b51392a
commit 6adccb3c17
4 changed files with 83 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
server/core/service.c
View File

@ -331,16 +331,22 @@ serviceStart(SERVICE *service)
{
SERV_PROTOCOL *port;
int listeners = 0;
if ((service->router_instance = service->router->createInstance(service,
service->routerOptions)) == NULL)
{
LOGIF(LE, (skygw_log_write_flush(LOGFILE_ERROR,
"%s: Failed to create router instance for service. Service not started.",
service->name)));
service->state = SERVICE_STATE_FAILED;
return 0;
}
if(service->router_instance == NULL)
{
/*
* This is the first time this service's router is being started or the
* previous attempt failed.
*/
if((service->router_instance = service->router->createInstance(service,
service->routerOptions)) == NULL)
{
LOGIF(LE, (skygw_log_write_flush(LOGFILE_ERROR,
"%s: Failed to create router instance for service. Service not started.",
service->name)));
service->state = SERVICE_STATE_FAILED;
return 0;
}
}
port = service->ports;
while (!service->svc_do_shutdown && port)
@ -353,7 +359,10 @@ int listeners = 0;
service->state = SERVICE_STATE_STARTED;
service->stats.started = time(0);
}
else
{
service->state = SERVICE_STATE_LISTENER_FAILED;
}
return listeners;
}
@ -408,6 +417,40 @@ int n = 0,i;
return n;
}
/**
* Try to start services that failed to start their listeners but successfully
* started their routers.
* @return Number of successfully started services
*/
int
serviceStartFailedListeners()
{
SERVICE *ptr;
int n = 0,i;
spinlock_acquire(&service_spin);
ptr = allServices;
spinlock_release(&service_spin);
while (ptr && !ptr->svc_do_shutdown)
{
if(ptr->state == SERVICE_STATE_LISTENER_FAILED)
{
n += (i = serviceStart(ptr));
if(i == 0)
{
LOGIF(LE, (skygw_log_write(
LOGFILE_ERROR,
"Error : Failed to start service '%s'.",
ptr->name)));
}
}
ptr = ptr->next;
}
return n;
}
/**
* Stop a service
*
@ -815,7 +858,6 @@ SERVICE *service;
return service;
}
/**
* Print details of an individual service
*

1
server/include/server.h
View File

@ -130,6 +130,7 @@ typedef struct server {
(SERVER_RUNNING|SERVER_MASTER|SERVER_SLAVE|SERVER_MAINT)) == \
(SERVER_RUNNING|SERVER_MASTER))
#define SRV_DOWN_STATUS(status) ((status & SERVER_RUNNING) == 0)
/**
* Is the server valid candidate for root master. The server must be running,
* marked as master and not have maintenance bit set.

3
server/include/service.h
View File

@ -152,6 +152,8 @@ typedef enum count_spec_t {COUNT_NONE=0, COUNT_ATLEAST, COUNT_EXACT, COUNT_ATMOS
#define SERVICE_STATE_STARTED 2 /**< The service has been started */
#define SERVICE_STATE_FAILED 3 /**< The service failed to start */
#define SERVICE_STATE_STOPPED 4 /**< The service has been stopped */
#define SERVICE_STATE_LISTENER_FAILED 5 /**< The service successfully started the
router but failed to start the listeners*/
extern SERVICE *service_alloc(const char *, const char *);
extern int service_free(SERVICE *);
@ -165,6 +167,7 @@ extern void serviceAddRouterOption(SERVICE *, char *);
extern void serviceClearRouterOptions(SERVICE *);
extern int serviceStart(SERVICE *);
extern int serviceStartAll();
extern int serviceStartFailedListeners();
extern void serviceStartProtocol(SERVICE *, char *, int);
extern int serviceStop(SERVICE *);
extern int serviceRestart(SERVICE *);

28
server/modules/monitor/mysql_mon.c
View File

@ -64,6 +64,8 @@
#include <dcb.h>
#include <modinfo.h>
#include "service.h"
/** Defined in log_manager.cc */
extern int lm_enabled_logfiles_bitmask;
extern size_t log_ses_count[];
@ -610,7 +612,7 @@ int num_servers=0;
MONITOR_SERVERS *root_master = NULL;
size_t nrounds = 0;
int log_no_master = 1;
int new_backends = 0;
if (mysql_thread_init())
{
LOGIF(LE, (skygw_log_write_flush(
@ -648,7 +650,10 @@ int log_no_master = 1;
nrounds += 1;
/* reset num_servers */
num_servers = 0;
/* reset new_backends */
new_backends = 0;
/* start from the first server in the list */
ptr = handle->databases;
@ -691,7 +696,13 @@ int log_no_master = 1;
!(SERVER_IS_IN_CLUSTER(ptr->server)))
{
dcb_call_foreach(DCB_REASON_NOT_RESPONDING);
}
}
if(SRV_DOWN_STATUS(ptr->mon_prev_status) &&
SERVER_IS_RUNNING(ptr->server))
{
new_backends++;
}
}
if (mon_status_changed(ptr))
@ -726,6 +737,17 @@ int log_no_master = 1;
ptr = ptr->next;
}
/**
* Some new servers are now running. Try to start services
* that failed to start their listeners but successfully created
* their router instances.
*/
if(new_backends > 0)
{
serviceStartFailedListeners();
}
ptr = handle->databases;
/* if only one server is configured, that's is Master */