Addition of -Wall to CFLAGS

Cleanup warnings produced by above with the exception of those files requiring reorganisation

modules/routing/Makefile

@@ -19,7 +19,7 @@
 # 13/06/13	Mark Riddoch		Initial routing module development
 
 CC=cc
-CFLAGS=-c -fPIC -I/usr/include -I../include -I../../include
+CFLAGS=-c -fPIC -I/usr/include -I../include -I../../include -Wall
 LDFLAGS=-shared
 TESTSRCS=testroute.c
 TESTOBJ=$(TESTSRCS:.c=.o)

modules/routing/readconnroute.c

@@ -46,6 +46,7 @@
 #include <spinlock.h>
 #include <readconnection.h>
 #include <dcb.h>
+#include <spinlock.h>
 
 static char *version_str = "V1.0.0";
 
@@ -144,7 +145,7 @@ int		i, n;
 				free(inst->servers[i]);
 			free(inst->servers);
 			free(inst);
-			return;
+			return NULL;
 		}
 		inst->servers[n]->hostname = strdup(server->name);
 		inst->servers[n]->protocol = strdup(server->protocol);
@@ -158,7 +159,7 @@ int		i, n;
 	 * insert this router instance into the linked list of routers
 	 * that have been created with this module.
 	 */
-	spinlock_aquire(&instlock);
+	spinlock_acquire(&instlock);
 	inst->next = instances;
 	instances = inst;
 	spinlock_release(&instlock);

modules/routing/testroute.c

@@ -74,6 +74,7 @@ GetModuleObject()
 static	ROUTER	*
 createInstance(SERVICE *service)
 {
+	return NULL;
 }
 
 /**
@@ -86,6 +87,7 @@ createInstance(SERVICE *service)
 static	void	*
 newSession(ROUTER *instance, SESSION *session)
 {
+	return NULL;
 }
 
 /**
@@ -104,4 +106,5 @@ closeSession(ROUTER *instance, void *session)
 static	int	
 routeQuery(ROUTER *instance, void *session, GWBUF *queue)
 {
+	return 0;
 }