hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added error check to mysql_backend.c to prevent unnecessary logging.

Browse Source
This commit is contained in:
VilhoRaatikka
2014-12-03 15:42:04 +02:00
parent 730cd67992
commit 6d98df0c37
1 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
server/modules/protocol/mysql_backend.c
View File

@ -834,15 +834,19 @@ static int gw_error_backend_event(DCB *dcb)
char buf[100]; char buf[100];
len = sizeof(error); len = sizeof(error);
if (getsockopt(dcb->fd, SOL_SOCKET, SO_ERROR, &error, &len) == 0) if (getsockopt(dcb->fd, SOL_SOCKET, SO_ERROR, &error, &len) == 0)
{
if (error != 0)
{ {
strerror_r(error, buf, 100); strerror_r(error, buf, 100);
LOGIF(LE, (skygw_log_write_flush( LOGIF(LE, (skygw_log_write_flush(
LOGFILE_ERROR, LOGFILE_ERROR,
"DCB in state %s got error '%s'.", "DCB in state %s got error '%s'.",
gw_dcb_state2string(dcb->state), STRDCBSTATE(dcb->state),
buf))); buf)));
} }
}
return 1; return 1;
} }
errbuf = mysql_create_custom_error( errbuf = mysql_create_custom_error(
@ -874,6 +878,8 @@ static int gw_error_backend_event(DCB *dcb)
len = sizeof(error); len = sizeof(error);
if (getsockopt(dcb->fd, SOL_SOCKET, SO_ERROR, &error, &len) == 0) if (getsockopt(dcb->fd, SOL_SOCKET, SO_ERROR, &error, &len) == 0)
{
if (error != 0)
{ {
strerror_r(error, buf, 100); strerror_r(error, buf, 100);
LOGIF(LE, (skygw_log_write_flush( LOGIF(LE, (skygw_log_write_flush(
@ -881,6 +887,7 @@ static int gw_error_backend_event(DCB *dcb)
"Error '%s' in session that is not ready for routing.", "Error '%s' in session that is not ready for routing.",
buf))); buf)));
} }
}
gwbuf_free(errbuf); gwbuf_free(errbuf);
goto retblock; goto retblock;
} }