MXS-2004 Drop support for thread_stack_size

- Cannot be supported with std::thread.
- Unlikely that the default size (8MB) would ever be too small and
  if it is, there is some problem.
- The stack size can be specified using 'ulimit -s' before starting
  MaxScale.
This commit is contained in:
Johan Wikman
2018-08-10 12:48:17 +03:00
parent 2515473fd4
commit 6db03d4b29
3 changed files with 13 additions and 11 deletions

View File

@ -163,13 +163,10 @@ will be used to manage the user connections.
#### `thread_stack_size` #### `thread_stack_size`
This parameter controls the stack size of the worker threads. The default value Deprecated in 2.3.
is 0, which means that the pthread default will be used. The size can be specified
as explained in detail [here](#sizes).
``` If you need to explicitly set the stack size, do so using `ulimit -s` before
thread_stack_size=5Mi starting MaxScale.
```
#### `auth_connect_timeout` #### `auth_connect_timeout`

View File

@ -53,6 +53,12 @@ The use of `router_options` with the binlogrouter module is deprecated in
MaxScale 2.3 and will be removed in a subsequent release. The MaxScale 2.3 and will be removed in a subsequent release. The
`router_options` should be converted into separate parameters. `router_options` should be converted into separate parameters.
### `thread_stack_size`
The `thread_stack_size` configuration parameter has been deprecated. If
you need to explicitly set the stack size, do so using `ulimit -s` before
starting MaxScale.
## Dropped Features ## Dropped Features
### Configuration Reloading ### Configuration Reloading

View File

@ -2060,11 +2060,10 @@ handle_global_item(const char *name, const char *value)
} }
else if (strcmp(name, CN_THREAD_STACK_SIZE) == 0) else if (strcmp(name, CN_THREAD_STACK_SIZE) == 0)
{ {
if (!get_suffixed_size(value, &gateway.thread_stack_size)) // DEPRECATED in 2.3, remove in 2.4
{ MXS_WARNING("%s has been deprecated. If you need to explicitly set the stack "
MXS_WARNING("Invalid value for '%s': %s.", CN_THREAD_STACK_SIZE, value); "size, do so with 'ulimit -s' before starting MaxScale.",
return 0; CN_THREAD_STACK_SIZE);
}
} }
else if (strcmp(name, CN_NON_BLOCKING_POLLS) == 0) else if (strcmp(name, CN_NON_BLOCKING_POLLS) == 0)
{ {