Add storing of statements to session
Statements can now be stored in the session object. This enables the retrieval of these statements at a later time. These will be used by readwritesplit to reroute failed reads to backup slaves.
This commit is contained in:
@ -46,6 +46,7 @@ MXS_BEGIN_DECLS
|
|||||||
struct dcb;
|
struct dcb;
|
||||||
struct service;
|
struct service;
|
||||||
struct filter_def;
|
struct filter_def;
|
||||||
|
struct server;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The session statistics structure
|
* The session statistics structure
|
||||||
@ -176,6 +177,11 @@ typedef struct session
|
|||||||
bool ses_is_child; /*< this is a child session */
|
bool ses_is_child; /*< this is a child session */
|
||||||
session_trx_state_t trx_state; /*< The current transaction state. */
|
session_trx_state_t trx_state; /*< The current transaction state. */
|
||||||
bool autocommit; /*< Whether autocommit is on. */
|
bool autocommit; /*< Whether autocommit is on. */
|
||||||
|
struct
|
||||||
|
{
|
||||||
|
GWBUF *buffer; /**< Buffer containing the statement */
|
||||||
|
const struct server *target; /**< Where the statement was sent */
|
||||||
|
} stmt; /**< Current statement being executed */
|
||||||
skygw_chk_t ses_chk_tail;
|
skygw_chk_t ses_chk_tail;
|
||||||
} SESSION;
|
} SESSION;
|
||||||
|
|
||||||
@ -370,4 +376,43 @@ SESSION* session_get_ref(SESSION *sessoin);
|
|||||||
*/
|
*/
|
||||||
void session_put_ref(SESSION *session);
|
void session_put_ref(SESSION *session);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief Store the current statement into session
|
||||||
|
*
|
||||||
|
* This creates an additional reference to the buffer. If an old statement is stored,
|
||||||
|
* it will be replaced with a clone of @c buf.
|
||||||
|
*
|
||||||
|
* @param session Session where statement is stored
|
||||||
|
* @param buf Buffer containing the current statement
|
||||||
|
* @param server Server where the statement is being executed
|
||||||
|
* @return True if statement was successfully stored, false if the cloning of @c buf failed.
|
||||||
|
*/
|
||||||
|
bool session_store_stmt(SESSION *session, GWBUF *buf, const struct server *server);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief Fetch stored statement
|
||||||
|
*
|
||||||
|
* The value returned by this call must be freed by the caller with gwbuf_free().
|
||||||
|
*
|
||||||
|
* @param session Session with a stored statement
|
||||||
|
* @return Stored statement or NULL if no statement was stored
|
||||||
|
*/
|
||||||
|
GWBUF* session_fetch_stmt(SESSION *session);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Fetch the stored target
|
||||||
|
*
|
||||||
|
* @param session Session whose target is fetched
|
||||||
|
* @return The server where the statement is executed or NULL if no statement is
|
||||||
|
* stored
|
||||||
|
*/
|
||||||
|
const struct server* session_fetch_stmt_target(const SESSION *session);
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Clear the stored statement
|
||||||
|
*
|
||||||
|
* @param session Session to clear
|
||||||
|
*/
|
||||||
|
void session_clear_stmt(SESSION *session);
|
||||||
|
|
||||||
MXS_END_DECLS
|
MXS_END_DECLS
|
||||||
|
@ -105,6 +105,8 @@ session_alloc(SERVICE *service, DCB *client_dcb)
|
|||||||
session->service = service;
|
session->service = service;
|
||||||
session->client_dcb = client_dcb;
|
session->client_dcb = client_dcb;
|
||||||
session->stats.connect = time(0);
|
session->stats.connect = time(0);
|
||||||
|
session->stmt.buffer = NULL;
|
||||||
|
session->stmt.target = NULL;
|
||||||
/*<
|
/*<
|
||||||
* Associate the session to the client DCB and set the reference count on
|
* Associate the session to the client DCB and set the reference count on
|
||||||
* the session to indicate that there is a single reference to the
|
* the session to indicate that there is a single reference to the
|
||||||
@ -395,6 +397,7 @@ static void session_free(SESSION *session)
|
|||||||
static void
|
static void
|
||||||
session_final_free(SESSION *session)
|
session_final_free(SESSION *session)
|
||||||
{
|
{
|
||||||
|
gwbuf_free(session->stmt.buffer);
|
||||||
MXS_FREE(session);
|
MXS_FREE(session);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -939,3 +942,43 @@ void session_put_ref(SESSION *session)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
bool session_store_stmt(SESSION *session, GWBUF *buf, const SERVER *server)
|
||||||
|
{
|
||||||
|
bool rval = false;
|
||||||
|
|
||||||
|
if (session->stmt.buffer)
|
||||||
|
{
|
||||||
|
/** This should not happen with proper use */
|
||||||
|
ss_dassert(false);
|
||||||
|
gwbuf_free(session->stmt.buffer);
|
||||||
|
}
|
||||||
|
|
||||||
|
if ((session->stmt.buffer = gwbuf_clone(buf)))
|
||||||
|
{
|
||||||
|
session->stmt.target = server;
|
||||||
|
/** No old statements were stored and we successfully cloned the buffer */
|
||||||
|
rval = true;
|
||||||
|
}
|
||||||
|
|
||||||
|
return rval;
|
||||||
|
}
|
||||||
|
|
||||||
|
GWBUF *session_fetch_stmt(SESSION *session)
|
||||||
|
{
|
||||||
|
GWBUF *rval = session->stmt.buffer;
|
||||||
|
session->stmt.buffer = NULL;
|
||||||
|
return rval;
|
||||||
|
}
|
||||||
|
|
||||||
|
const SERVER* session_fetch_stmt_target(const SESSION *session)
|
||||||
|
{
|
||||||
|
return session->stmt.target;
|
||||||
|
}
|
||||||
|
|
||||||
|
void session_clear_stmt(SESSION *session)
|
||||||
|
{
|
||||||
|
gwbuf_free(session->stmt.buffer);
|
||||||
|
session->stmt.buffer = NULL;
|
||||||
|
session->stmt.target = NULL;
|
||||||
|
}
|
||||||
|
Reference in New Issue
Block a user